Code Monkey home page Code Monkey logo

Comments (2)

pkasarda avatar pkasarda commented on June 25, 2024

What I have done is this

// fromAction returns
Promise<TypedResponse<FormActionFailure<Schema> | FormActionSuccess<D>>>

// and code
if (...) {
      return path ? redirect(path) : json({ errors: null, data: result.data });
    } else {
        return json({ errors: result.errors, values: result.values }, { status: 422 });
   }

then types are correct

    // this is when we have errors you have access to errors and values (internally used by HookForm)
    if (actionData?.errors) {
        actionData.errors;
        actionData.values;

        // if errors are null we have access to response from action
    } else if (actionData?.data) {
        actionData.data.abc;
        // @ts-expect-error this should trigger error
        actionData.data.nonExist;
    }

issue is here https://github.com/seasonedcc/remix-forms/blob/main/packages/remix-forms/src/mutations.ts#L108
it returns Promise<Response>

from remix-forms.

atoi avatar atoi commented on June 25, 2024

Yes, spend some time thinking on that piece already...
First I was considering changing the return type to be dependent on successPath value, but we also need to account for error case, so we'd need a type guard in the handler anyways...
As it seems there's must be some app code to properly type the result anyways -- no need to touch the library code then.

from remix-forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.