seadexgmbh / yasmine Goto Github PK

Running cmake -DCPP_VERSION=14 -DSX_NO_LOGGING=ON .. caused a Cmake error for me citing "SX_ASSERT" was not defined. Removing the SX_NO_LOGGING bit succeeds. Can you reproduce with a clean build?

Info from pull request: "The current file path is neither relative nor absolute and causes build failures."

Please approve my pull request for the fix.

Compiling yasmine with g++ (tested 4.9 and 5.4) with following compile commands

cmake -G "Unix Makefiles" -DCMAKE_CXX_FLAGS=-m64 .
make

fails with
yasmine/yasmine/color_mapping.cpp: In member function ‘sxy::color sxy::color_mapping::get_color(sxy::log_level) const’:
yasmine/yasmine/color_mapping.cpp:68:16: error: ‘color’ is not a class, namespace, or enumeration color color = color::C_WHITE;

Apparently the compiler tries to use the object 'color' instead of the class 'color' at this position.
Changing the name for the variable fixed compilation for me.

In the current version of yasmine, some of the macros were not ported to the new method signature, thus any compilations will fail when these macros are used.

The missing macros are (respectively their SELECT variants):

• Y_BEHAVIOR_ACTION
• Y_GUARD_ACTION

This:
[ this ]( const sxy::event& _event ){ SX_UNUSED_PARAMETER(_event); _action }
should be replaced with
[ this ]( const sxy::event& _event, sxy::event_collector& _event_collector ){ SX_UNUSED_PARAMETER(_event); SX_UNUSED_PARAMETER(_event_collector); _action }

shallow_history_impl.cpp is the same with deep_histroy_impl.cpp, but they are definitely different in UML definition. What's wrong with they two? Am I using them in wrong way?

@SeadexWP @SeadexTM

After installing yasmine using 'make install' and trying to use the headers from /usr/local/include/yasmine, my code includes yasmine.hpp. However, yasmine.hpp attempts to include a few files that aren't present in /usr/local/include/yasmine (haven't been installed):

#include "backward_compatibility.hpp"

#include "essentials/compatibility/compatibility.hpp"
#include "essentials/compatibility/chrono.hpp"
#include "essentials/compatibility/thread.hpp"

These files should be included in the installation. It seems that the library hasn't been tested with sample code that accesses the library from /usr/local/include.

Hello! First of all, thank you for such a great library :)

Y_BEHAVIOR_FUNCTION2 and Y_GUARD_METHOD2 fails to compile when passing template class member function to them only on GCC/Ubuntu. MSVC/Windows works fine. The fix is to use "typename std::remove_pointer" instead of "std::remove_pointer" inside assemblies.hpp.