sdrapkin / securitydriven.core Goto Github PK

Hi,

I find your implementation of per-thread caching clever and interesting. I think there is a pathological edge case in .NET 5 and earlier and a more likely edge case in .NET 6 that will cause a problem, however.

.NET 6 changes Environment.ProcessorCount to return a number less than the number of processors in two cases:

• If the process is running with CPU affinity, the number of processors that the process is affinitized to.
• If the process is running with a CPU utilization limit, the CPU utilization limit rounded up to the next whole number.

In this case I believe Thread.GetCurrentProcessorId can return a number greater than Environment.ProcessorCount (especially in the case that the process affinity is set to, say, the seventh and eight CPU cores).

In all versions of .NET "The value returned by this API is fixed at .NET runtime startup for the process lifetime" and in certain virtualisation environments support hot add vCPU so more processors could be added after the application starts.

In any case, if either of the above situations transpires then this line will throw an IndexOutOfRangeException.

Please note I do not have .NET 6 or virtualization software with hot add vCPU on hand, so I apologise if this is a hypothetical. The breaking change documentation for .NET 6 is here and it suggests this might already be a problem when running on Unix-based hosts.

Hi, could you please clarify

• is CryptoRandom in this library different from main lib (SecurityDriven.Inferno) and how?
• which lib is better to use?
  Thanks

Wanted to see if this is something that should possibly worth persuing as contrib to core .NET itself rather then standalone lib.

Cloned the repo and tried to build in Visual Studio but I get the following error:

"Error signing output with public key from file 'Inferno.snk' -- File not found."

I'm not sure how to go about fixing this since I haven't used the AssemblyOriginatorKeyFile property before. Any help is appreciated!