sdoehren / day-night-cycle Goto Github PK

Describe the bug
When changing the time in the calendar, the day/night cycle only changes for the currently active scene, but not for any other scene, players are in.

To Reproduce
Steps to reproduce the behavior:

1. Open a scene
2. Click on 'activate'
3. Change day time
4. Note, that the Darkness-Level changes
5. go to other scene
6. change time
7. Scene doesn't darken, until activated and changed time

Expected behavior
Time works on a global basis: So when the party splits, and 2 Maps are considered active, both maps should update.

Screenshots
Video

Foundry:

• Foundry Version: 9 build 269
• System DND5E
• Module Version: 0005

Desktop (please complete the following information):

• OS: Win 11
• Browser: Vivaldi/Chrome/Edge
• Version Latest

Describe the bug

I know the module is technically 'unsupported' as per the readme, but I thought I'd hail Mary this bug I found!

See video attached. darkness is cycling when turning on simple calendar + small time. This happens when all other mods are disabled except simple calendar, small time and day night cycle.

When the light is fully dark or fully light (night vs light) no visual errors. But when transitioning to dusk or dawn light values it seems to just ease in and reset.

To Reproduce
Steps to reproduce the behavior:

1. Enable simple calendar, small time, day/night cycle.
2. Load in my calendar (https://pastebin.pl/view/6a1015da)
3. Go to a dusk or dawn time
4. Press play on simple calendar to start the clock.
5. Unpause foundryVTT
6. It brakes?

Expected behavior
There should be a smooth transition to whatever light value is set/desired, then that value is held and slowly adjusted as simple calendar/smalltime progress the clock.

Screenshots
See video

Foundry (please complete the following information):

• Foundry Version v10 291
• System 2.0.3
• Module Version 0006

Desktop (please complete the following information):
Running on Oracle Server

• OS: Client: (Windows 10) Server: Canonical-Ubuntu-20.04-aarch64-2021.12.01-0
• Browser Chrome
• Version Version 109.0.5414.75 (Official Build) (64-bit)

As the Foundry v12 Stable was released it would be great to add new version compatibility for Day Night Cycle module.

Describe the bug
Upon installing day night cycle, the 'Configure Scene' screen in Foundry stops saving changes.

To Reproduce
Steps to reproduce the behavior:

1. Confirm you are able to save changes made on any 'Configure Scene' screen
2. Go to 'Configure Modules'
3. Click on checkbox for 'Day Night Cycle'
4. Save changes
5. Wait for scene to reload
6. Open 'Configure Scene' screen on any Scene.
7. Make any change and attempt to click 'Save Changes'

Expected behavior
In normal conditions, either an error will come up if a parameter is incorrect, or the window will close.

Foundry (please complete the following information):

• Foundry Version 9 build no. 269
• System DnD5e
• Module Version 0005

Desktop (please complete the following information):

• OS: Windows 10
• Browser chrome
• Version [e.g. 22] 102.0.5005.115

Additional context
See below for currently active modules

Many mapmakers release day/night variants of the same scenes. It would be very cool to be able to automatically phase them in/out at a darkness level threshold

Hi,

Thanks for your module and work. Does it possible to update the module for the v10 ?

In the module.json I can see :

  "minimumCoreVersion": "9",
  "compatibleCoreVersion": "9",

Happy dev

Relatively new Foundry player here, setting up a game on Forge.

I have been setting up my installation with a variety of modules that I want for my game, including Simple Calendar, Day Night Cycle, and Weather Control.

I created a simple "campsite" scene to test to make sure everything was working and that I knew how to use it, and I noticed that Day Night Cycle wasn't functioning properly.

I double-checked the scene settings and couldn't find anything amiss.

I then thought maybe there's a conflict, so with the help of Find the Culprit, I deactivated every module except for Simple Calendar, Day Night Cycle, and libWrapper. Day Night Cycle still doesn't do anything.

Am I missing something? Or is there a compatibility issue with Foundry v9?

Attaching a screencap of the scene config. Let me know what other info might be helpful and I'll get that to you. Thank you!

I need my game to only get as light as 0.5 because it's Icewind Dale and the sun doesn't come up all the way..
The settings seem to indicate that I can do this, but instead it just stops the scenes from getting fully dark

To Reproduce
Steps to reproduce the behavior:

1. Simply set a maximum light level
2. let time pass
3. see that it still gets fully light out
4. see that it fails to get fully dark

Expected behavior
I expected that a maximum light level "for worlds that do not reach full light", would limit how bright a scene gets

Foundry (please complete the following information):

• Foundry Version 10 (291)
• System DnD5e
• Module Version 0006

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Version 113.0.5672.129

Describe the bug
When using the default settings with simple calendar. The darkness is not changed. Instead there is a new error shown every second. See the screenshots.

To Reproduce
Steps to reproduce the behavior:

1. Activate Module
2. Unpause game
3. See error

Expected behavior
Change darkness according to time.

Screenshots

Foundry (please complete the following information):

• Foundry Version: latest (9.242)
• System: Splittermond latest (0.7.3)
• Module Version: latest (0004)

Desktop (please complete the following information):

• OS: Arch Linux
• Browser: Chromium 96.0.4664.110

Additional context

• German and english translations affected
• Changing darkness by hand to "reset" it, did nothing.
• Do you need anything else from me?

Everything is the newest stable version possible.
Not sure if a bug - because it doesn't seem to throw errors. But isn't "NaN" a thing people try to avoid?