scrapy / xtractmime Goto Github PK

@Gallaecio @elacuesta Please discuss here the basic input-output structure of the API.

Can you please mention the issues you were talking about related to API in the main scrapy repo?

According to https://mimesniff.spec.whatwg.org/#interpreting-the-resource-metadata, the logic to check whether the body is binary or not only needs to be applied when the MIME type is one of: text/plain, text/plain; charset=ISO-8859-1, text/plain; charset=iso-8859-1, text/plain; charset=UTF-8.

However, xtractmime seems to apply that logic to every variant of text/plain

>>> from xtractmime import extract_mime
>>> extract_mime(b'\x00\x01\xff', content_types=(b'text/plain; charset=windows-1252',), http_origin=True)
b'application/octet-stream'  # expected: b'text/plain'
```