scrap-mods / sm_server Goto Github PK

I suggest adding an interface for exchanging packets with clients:

public interface IClientConnection : IDisposable
{
    public void ReceivePacket<T>(byte packetId, Action<IClient, T> handler) where T : new, IPacket;
    public void SendPacket<T>(T packet) where T : new, IPacket;
}

An implementation of this interface that uses Steamworks.SocketManager could be called SteamworksConnection.

The new constraint and the packetId parameter in IClientConnection.ReceivePacket<T> would make it possible to match, create and deserialize packets without using reflection. An extension method could also be added to allow you to subscribe to incoming packets without specifying the packetId that would get it through reflection.

The existing code should be moved to a separate project in a separate directory to separate it from other projects with unrelated features that may be added in the future. The project could be called ScrapMods.Server.Networking.

The parameter types in IPacket.Serialize and IPacket.Deserialize should be changed from BigEndianBinaryWriter and BigEndianBinaryReader to BinaryWriter and BinaryReader respectively for decoupling.