scozv / algo-js Goto Github PK

From Algo.js of Google Code on September 21, 2013 21:24:40

we use UnionFind as a type, so that it should be merged into window.T

Original issue: http://code.google.com/p/algo-js/issues/detail?id=17

From Algo.js of Google Code on July 31, 2013 14:10:40

What steps will reproduce the problem?

1. we label vertex using index of itself by default
2. we may mark vertex as -1 when we visited it
3. however, we can not mark vertex as -1 when we push it into stack during dfs
4. we have to mark v as 'v' for visited, mark it as 'm' for marked

Please use labels and text to provide additional information.
try to find a better way to represent different meanings from different labels.

enumeration, 'v' | 'm' ..., or just some numbers, like below?
-1 for initial status, unmarked, unvisited;
0 for marked (has been in a stack)
1, 2, 3... for visited order

Original issue: http://code.google.com/p/algo-js/issues/detail?id=8

From Algo.js of Google Code on August 11, 2013 15:53:52

set g.clone() = null in the end of graph algorithm

Original issue: http://code.google.com/p/algo-js/issues/detail?id=16

From Algo.js of Google Code on July 31, 2013 19:12:42

What is the expected output? What do you see instead? as right now, we test graph build and graph search by debug. we should write out unit test asap.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=9

From Algo.js of Google Code on August 01, 2013 19:30:15

What steps will reproduce the problem?

1. when we sort an array
2. if we just want to take the first 5 elements
3. what shall we do?

What is the expected output? What do you see instead?
we should write arr.take(5);

Please use labels and text to provide additional information.
so as skip()

Original issue: http://code.google.com/p/algo-js/issues/detail?id=11

rev b206841

1) graph algorithm dijkstra on graph:

      AssertionError: expected Array [ 0, 28, 27, 7, 44, 96, 107, 4, 47, 58, 39, 124, 39, 38, 48 ] to equal Array [ 0, 22, 27, 7, 23, 11, 17, 4, 31, 36, 23, 35, 23, 38, 42 ] (at '1', A has 28 and B has 22)
      + expected - actual

       [
         0
      -  28
      +  22
         4
      -  47
      -  58
      -  39
      -  124
      -  39
      +  31
      +  36
      +  23
      +  35
      +  23
         38
      -  48
      +  42
         27
         7
      -  44
      -  96
      -  107
      +  23
      +  11
      +  17
       ]

      at Assertion.fail (node_modules/should/lib/assertion.js:92:17)
      at Assertion.Object.defineProperty.value (node_modules/should/lib/assertion.js:164:19)
      at Context.<anonymous> (test/q.js:28:94)

From Algo.js of Google Code on August 01, 2013 20:26:48

after revision f1cb92d , we try to find out more info from topological sort, such as is there cycle?

we should add more properties validation function for graph type.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=12

From Algo.js of Google Code on September 21, 2013 21:26:42

See unit test of graph, we place lots of input edges data in q-graph.js. It is better to read input file.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=18

From Algo.js of Google Code on August 09, 2013 14:47:54

What steps will reproduce the problem?

1. in graph, or stack type...
2. we create an instance of some errors in constructor
3. we throw error instance from other code What is the expected output?

What do you see instead?
it is expected to see a correct error stack, instead of an error stack including just constructor address

Please use labels and text to provide additional information.
try to use const string for error message, instead of error instance.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=15

From Algo.js of Google Code on September 28, 2013 17:47:29

What steps will reproduce the problem?

1. we create a union(n) which has an id array with index from 0 to n-1 (inclusive)
2. we use it in our Kruskal MST algorithm, where the index of vertex we pass into the union is from 1 ton (inclusive)

What is the expected output? What do you see instead?
How it still works, without any out of index range error?

Please use labels and text to provide additional information.
run following codes may get some answers:

var find = new union(10);
find.union(3, 10);
find._id.length;
find._id[10];

Original issue: http://code.google.com/p/algo-js/issues/detail?id=19

From Algo.js of Google Code on July 31, 2013 14:01:15

What steps will reproduce the problem?

1. we increase graph.v as number of vertex during pushing edge into graph,
2. however, we may never increase the number to match the last vertex (sink vertex), since there is no edge from that vertex
3. so, in topological sorting, we may label the sink vertex using a number which is less than the actual number of vertex

Please provide any additional information below.
we need two properties for n, the number of vertex, and for the number of valid vertex, which maybe mean how many vertex we haven't visited.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=7

From Algo.js of Google Code on August 09, 2013 14:41:41

What steps will reproduce the problem?

1. some input data may pass Tarjan
2. some may not
3. see revision 7d99353

What is the expected output? What do you see instead?
Tarjan should work as Kosaraju Please use labels and text to provide additional information. how to use stack simulate recursion correctly?

Original issue: http://code.google.com/p/algo-js/issues/detail?id=14

From Algo.js of Google Code on July 15, 2013 10:14:07

What steps will reproduce the problem?

1. merge sort an array containing 100000 elements
2. sort seems to be very slow What is the expected output?

What do you see instead?
merge sort should be finished in less than five seconds, at least.
no output after one minute.

What version of the product are you using? On what operating system?
it doesn't matter.

Please provide any additional information below.
nothing else.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=1

From Algo.js of Google Code on July 18, 2013 22:03:27

throw Error('not implemented').

Original issue: http://code.google.com/p/algo-js/issues/detail?id=3

From Algo.js of Google Code on July 31, 2013 23:13:36

we use (isNaN(x = +x)) to valid whether x is numeric value or not.

according to isNumber test, the improvement for integer validation or numeric validation should be applied.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=10

From Algo.js of Google Code on November 22, 2013 21:22:13

What steps will reproduce the problem?

1. take the graph 1->2->4, 1->3->4, 3->2
2. run Graph.topologicalSort(g)

What is the expected output? What do you see instead?
the expected order is 1->3->2->4, BUT we get 1->2->3->4

Issue occurs at comment // v has been add into frontier

Original issue: http://code.google.com/p/algo-js/issues/detail?id=20

From Algo.js of Google Code on July 23, 2013 19:39:34

in rev 9259b3f, we have a draft version of time test for sorting algorithm.

how to apply statistic knowledge to the test is what we need improve, such as curve fitting, confidence level, etc.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=5

for instance:

array.map() returns another new array,

LinkedList.map() returns another LinkedList,

Tree.map() should also return another new Tree

From Algo.js of Google Code on July 27, 2013 19:07:36

in most sorting functions, we have fn and compare functions as the sorting parameters. actually, they can be merged into one function like compare: (x, y) => fn(x) - fn(y).

Original issue: http://code.google.com/p/algo-js/issues/detail?id=6

From Algo.js of Google Code on July 22, 2013 21:41:01

get false for a sorted array.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=4

From Algo.js of Google Code on August 02, 2013 17:41:55

What steps will reproduce the problem?

1. debug stop before sort connect info of scc using 875714 vertex graph data
2. run heap sort, or merge sort is faster than quick sort by feeling

Please use labels and text to provide additional information.
inspect into it, see whether clone array is slow or not.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=13

From Algo.js of Google Code on July 15, 2013 13:30:52

each time we get the file for input, we have to process the file by splitting to lines array.

why not modify the IO handler function to accept the lines array and the function processing each line.

Original issue: http://code.google.com/p/algo-js/issues/detail?id=2