Comments (5)
zachary822
commented on May 24, 2024
1
Code:
{-# LANGUAGE OverloadedStrings #-}
module Main where
import Debug.Trace
import Network.Wai
import Web.Scotty
rewriteMiddleware app req sendResponse = do
app req{queryString = [("a", Just "b")]} sendResponse
main :: IO ()
main = do
scotty 3000 $ do
middleware rewriteMiddleware
get "/" $ do
p <- queryParams
req <- request
traceShowM p
traceShowM req
text "riveting content!"Stdout:
Setting phasers to stun... (port 3000) (ctrl-c to quit)
[]
Request {requestMethod = "GET", httpVersion = HTTP/1.1, rawPathInfo = "/", rawQueryString = "", requestHeaders = [("Host","localhost:3000"),("User-Agent","Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:120.0) Gecko/20100101 Firefox/120.0"),("Accept","text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8"),("Accept-Language","en-US,en;q=0.5"),("Accept-Encoding","gzip, deflate, br"),("DNT","1"),("Connection","keep-alive"),("Upgrade-Insecure-Requests","1"),("Sec-Fetch-Dest","document"),("Sec-Fetch-Mode","navigate"),("Sec-Fetch-Site","none"),("Sec-Fetch-User","?1")], isSecure = False, remoteHost = 127.0.0.1:50733, pathInfo = [], queryString = [("a",Just "b")], requestBody = <IO ByteString>, vault = <Vault>, requestBodyLength = KnownLength 0, requestHeaderHost = Just "localhost:3000", requestHeaderRange = Nothing}
from scotty.
ocramz
commented on May 24, 2024
Thank you for filing this!
…On Tue, 28 Nov 2023 at 00:13, Zachary Juang ***@***.***> wrote:
https://hackage.haskell.org/package/wai-extra-3.1.13.0/docs/Network-Wai-Middleware-Rewrite.html
This only updates the Request.queryString and doesn't update
Request.rawQueryString, therefore scotty routes don't pickup on the
rewritten queryString and continues to read from the old rawQueryString.
According to
https://hackage.haskell.org/package/wai-3.2.3/docs/Network-Wai.html#v:rawQueryString
rawQueryString should not be modified.
I'm thinking we should read from queryString instead, to allow for people
that need to modify the queryString while keeping rawQueryString read-only.
—
Reply to this email directly, view it on GitHub
<#348>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNBDKF5FJF65KUX3S2FFZTYGSU2BAVCNFSM6AAAAAA74GG3ZOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTENBZHAZDSMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from scotty.
ocramz
commented on May 24, 2024
@zachary822 would you be able to provide a minimal repro for this? Thanks!
from scotty.
ocramz
commented on May 24, 2024
The solution seems to be fixing this line only: https://github.com/scotty-web/scotty/blob/e6a97352229d9e1811193ff93d2eccf7e1ab9526/Web/Scotty/Route.hs#L163C22-L163C22
from scotty.
zachary822
commented on May 24, 2024
I made a simple fix.
from scotty.
Related Issues (20)
- Expose Cookie via the main interface HOT 1
- Add doctest
- Variable not in scope: pathParam In examples/basic.hs file HOT 3
- Establish API deprecation and cleanup policy
- SQLite module HOT 2
- Accept text-2.1 HOT 1
- Update README with Stackage badges
- Undocumented change to the `File` type definition HOT 1
- Dependency upper bounds HOT 1
- Exception information is lost HOT 7
- Update CI to new action
- Add changelog for #374 HOT 1
- warp-3.4 not accepted HOT 3
- Optional validation of header contents HOT 11
- Don't export ParseRequestBodyOptions HOT 1
- Cloned Repo and Tried to Run `examples/basic.hs` HOT 5
- runhaskell doesn't work reliably for all users. Update quickstart in the README HOT 2
- `files` function capturing empty input-file field. HOT 7
- Add GHC 9.10 to CI HOT 1
- network-3.2 not accepted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scotty.