Comments (7)
Looks like a bug, but could you share first what scotty
version is running?
from scotty.
Hi, it's 0.22
from scotty.
@tusharad could you please check whether previous versions of scotty have the same behaviour? I suspect not because the changes introduced in 0.22 move the files parsing behaviour to wai-extra.
We don't even have a test for the "no files" case, fwiw.
from scotty.
Hi @ocramz ,
I used this example.
Even after using the older version (0.12.1). On submitting without uploading file, It is given us list containing elements with filename as "\"\""
.
post upload code:
post "/upload" $ do
fileList <- files
liftIO $ print fileList
text **"done"**
from scotty.
Thanks @tusharad for checking! This is odd and unintuitive behaviour, but I'm at least glad that it didn't appear in 0.22 .
Question now is, what's the cause of this, and how do we fix it?
from scotty.
Hi @ocramz,
Upon investigating the files
and filesOpts
functions, I discovered that both rely on the formParamsAndFilesWith
function. This function, in turn, utilizes getFormParamsAndFilesAction
, which ultimately utilizes sinkRequestBodyEx
from wai-extra
. Location of sinkRequestBodyEx
function.
I've provided two images illustrating the output of wholebody
and fs
at this location:
It appears that sinkRequestBodyEx
parses the wholebody
bytestring, extracting the filename and file content. However, I don't believe the issue lies with sinkRequestBodyEx
itself, as it simply performs parsing.
To address this, I propose a simple solution: apply a filter function after sinkRequestBodyEx
to exclude files with an empty filename ("\"\""
). This solution has worked effectively in my testing.
Here's the proposed modification within the getFormParamsAndFilesAction
function:
bs <- getBodyAction bodyInfo opts
let
wholeBody = BL.toChunks bs
(formparams, fs) <- parseRequestBodyExBS istate prbo wholeBody (W.getRequestBodyType req) `catches` handleWaiParseSafeExceptions
-- changed here
let fs' = filter emptyFile fs
return (convertBoth <$> formparams, convertKey <$> fs')
where emptyFile (_,fInfo) = ("\"\"" /= (W.fileName fInfo))
Please review and let me know if this approach aligns with your expectations. If approved, I'll proceed with creating a PR.
Thank you!
from scotty.
@tusharad Yes, this fix seems sensible but it's also a breaking change that should be documented as such.
Happy to review your PR!
from scotty.
Related Issues (20)
- Add doctest
- Variable not in scope: pathParam In examples/basic.hs file HOT 3
- Establish API deprecation and cleanup policy
- SQLite module HOT 2
- Accept text-2.1 HOT 1
- Update README with Stackage badges
- Undocumented change to the `File` type definition HOT 1
- Dependency upper bounds HOT 1
- Exception information is lost HOT 7
- Update CI to new action
- Add changelog for #374 HOT 1
- warp-3.4 not accepted HOT 3
- Optional validation of header contents HOT 12
- Don't export ParseRequestBodyOptions HOT 1
- Cloned Repo and Tried to Run `examples/basic.hs` HOT 5
- runhaskell doesn't work reliably for all users. Update quickstart in the README HOT 2
- Add GHC 9.10 to CI HOT 1
- network-3.2 not accepted HOT 3
- Allow customizing status of redirect
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scotty.