scottschluer / geolocation Goto Github PK

Can be reproduced by adding a "5000" radius to the example program and searching for all locations within 5000 miles. It will return 0 locations.

First, thanks for creating this great library!

Today, GetDistance accepts a decimalPlaces parameter which defaults to 1. I find this unintuitive from an API perspective; if I want to do rounding on the value I can easily do it myself after calling GetDistance, I would not expect that method to do it for me. I definitely would not expect it to round to 1 decimal place; that feels arbitrary to me especially when we support different distance units and so 1 decimal place implies many different levels of precision.

Another oddity with this is that the library uses .NET's default "banker's rounding" under the hood (MidpointRoundingMode.ToEven), which doesn't feel like an appropriate choice for coordinate math (I would use AwayFromZero).

My suggestion would be to take a breaking change and simply remove the rounding behavior from GetDistance. Consumers can easily call Math.Round themselves on the result if they so desire.

Credit to @cmpcdaly for the idea and most of the implementation.

In https://github.com/scottschluer/geolocation/blob/master/NuGet/Geolocation.nuspec file
There is such lines:
file src="..\Geolocation\bin\Debug\Geolocation.dll" target="lib\Geolocation.dll
file src="..\Geolocation\bin\Debug\Geolocation.pdb" target="lib\Geolocation.pdb"

It mean that you nuget package build from debug mode, is not it?

Hi @scottschluer I hope you are well. If you're open to it I'm happy to build an updated NuGet package for you that targets both .NET Core and .NET Framework, if you'd be interested. Selfishly, it would help me, too. If not, please feel free to close the issue.

I checked with google maps for getting a distance in a straight line from point A to B in kilometers and it was accurate to 2 decimal points. Google doesn't seem to return more than 2 numbers after the "." so I have came here to ask.
Is it accurate to a meter?

Hi Scott,

Thanks for making this code public. Any interest in submitting this to NuGet? Happy to help if you're open to it!

Cheers
Joel

Why american's developers only calculate distance with miles and never think about all the rest of the "standardized-world-developers" ?

Please, use the ISU (International System of Units) by default... it has been released in 1960... so any length must be expressed in meters (or cm/Km/...)

https://en.wikipedia.org/wiki/International_System_of_Units

And if you want to add an overload/option to get the result on miles, I'm not against ;-)
(For example, MAUI Location Extension ask the unit (Km or Miles) in parameter : https://www.andreasnesheim.no/calculating-distance-between-your-device-and-a-location-with-net-maui/)

Some rockets have already exploded in the past for this kind of imperial units problems... with unfortunate human deaths.

Hello,

I'd like to make a request for the bearing method to return both true and magnetic bearing.

Thanks

Hi all,

If you have time, would you please sign the DLL?

Thanks,
Have a nice day,

Hello,
I'd like to use this project in my code, what is the license for it?

Thanks.

Hi,

This library is really great and easy to use - so first thank you.

It's not a big deal, but when referencing the package downloaded from NuGet, I receive this warning when building my project.

Warning	NU1701	Package 'Geolocation 1.1.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project.

This is a shame because I see that there already is a project which is based upon .NET Standard. This issue could be fixed if the files inside the NuGet package were just rebuild targeting the .NET Standard.

Thanks,
Andrew

What is the licensing of this code?

Looking for a nice small C# library for GIS stuff and this package looks very promising.

Would it be possible to add a method that returns a Coordinate based on a source + distance + bearing? e.g.

Coordinate origin = new Coordinate(34.0675918, -118.3977091);
double bearing = 124; // Degrees
double distance = 10000; // Meters
Coordinate destination = GeoCalculator.GetCoordinate(origin, bearing, distance);

I can probably implement this myself using https://adhamhurani.blogspot.com/2010/08/c-how-to-add-distance-and-calculate-new.html and submit a pull request if this is an acceptable feature (and could you let me know the method name you would prefer?)

Hello it seems that nuget shows only version 1.1.1 https://www.nuget.org/packages/Geolocation.NetStandard
And the newset one is 1.2.1 https://github.com/scottschluer/geolocation/releases/tag/1.2.1
Can someone update nuget ?