scorelab / kute Goto Github PK

Issue

There are no zoom in or zoom out buttons available in the map view

Expected behavior

There should be zoom in and out buttons in the map view. There is a fab icon covering the possible location for zoom controls. We can set the fab action to the navigation menu and remove it to provide space for zoom controls.

Steps to reproduce

1. Open app
2. Login with valid credentials
3. Observe map

Would you like to work on this issue?

Yes and I can send a PR for review!

There are no templates available for reporting issues and pull requests. If there is a template which everyone can follow, then all the information relevant to the issue and details of PRs will be available!

Short, Informative Title

In-app Gradle file, all dependency still using 'compile' configuration, So we have to upgrade as per new guidelines.

Issue Explanation (Background, Importance, etc.)

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'API'.
It will be removed at the end of 2018. So we have to upgrade app level Gradle file.

Expected Behaviour

A project should run properly with all dependencies.

Actual Behaviour

A project is not compiling.

Steps to Reproduce Actual Behaviour

1. Clone on a local machine
2. Open kute-android-app from Android Studio
3. Download required SDK Tool

Additional Information

Greetings Mentors!

The technologies I identified in the project that should be used to generate the .gitignore are IntelliJ, Java, Python, macOS, Gradle, and Android.

Please inform if I missed something.

Once the app is open, clicking on signup button crashes the application!

Currently, the splash screen is implemented via a dedicated splash activity which is not an optimal way of implementing splash screens. Moreover setting up Firebase and other functionalities in the splash activity is also suboptimal. The correct way of implementing splash screens as stated by Google can be found on the link below :-
https://android.jlelse.eu/launch-screen-in-android-the-right-way-aca7e8c31f52
All the networking code should be done in the main activity while showing the progress bar. This is how most of the Google Apps implement splash screen.

Hello everyone. Before you make an issue, please refer to this template. Thank you.

Short, Informative Title

Issue Overview

Issue Explanation (Background, Importance, etc.)

Expected Behaviour

Actual Behaviour

Steps to Reproduce Actual Behaviour

Additional Information

When I was in the private vehicle section, and turn the screen (change the orientation) app crashed.

Merge conflict is not resolved on commit f499786
kute-android-app/gradle/wrapper/gradle-wrapper.properties

This repos should follow Gitflow workflow and follow are the items you have to check.

• There is a master branch and a develop branch.
• master branch is locked for direct commits and,
  • Require pull request reviews before merging is active
  • Require status checks to pass before merging is active
    • Require branches to be up to date before merging
    • Appropriate Status checks are required
  • Enforce all configured restrictions for administrators is active
  • Restrict only maintainers group can push to the master branch
• develop branch is locked for direct commits and,
  • Require pull request reviews before merging
    • Dismiss stale pull request approvals when new commits are pushed is active
  • Require pull request reviews before merging is active
  • Require status checks to pass before merging is active
    • Require branches to be up to date before merging
    • Appropriate Status checks are required
  • Enforce all configured restrictions for administrators is active
  • Restrict only maintainers group can push to the master branch

Place where change is to be done:
kute-android-app/app/src/main/res/layout/taskselection.xml

Reason:
The UI for TaskSelection.java needs some changes...

Would you like to work on this issue?
Yes and I can send a PR for review!

Actual Behavior
When a user logs into the app using a Facebook account, the profile picture remains the same even if we upload a new image to facebook

Expected Behavior
When user updates his facebook profile picture, Kute profile picture should change accordingly

Complete SignOut activity

Issue

App goes to the splash screen after pressing the back button to the launcher screen from any activity following it

Expected behaviour

The app should be paused if the back button is pressed while on an immediate activity of the splash activity

Steps to reproduce

Open app
Press the back button after the splash terminates
Would you like to work on this issue?

Yes and I can send a PR for review!

And this what happen in logcat.

W/System.err( 4216): android.view.InflateException: Binary XML file line #1: Error inflating class
W/System.err( 4216): at android.view.LayoutInflater.createView(LayoutInflater.java:623)
W/System.err( 4216): at com.android.internal.policy.impl.PhoneLayoutInflater.onCreateView(PhoneLayoutInflater.java:56)
W/System.err( 4216): at android.view.LayoutInflater.onCreateView(LayoutInflater.java:672)
W/System.err( 4216): at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:697)
W/System.err( 4216): at android.view.LayoutInflater.inflate(LayoutInflater.java:472)
W/System.err( 4216): at android.view.LayoutInflater.inflate(LayoutInflater.java:400)
W/System.err( 4216): at android.view.LayoutInflater.inflate(LayoutInflater.java:353)
W/System.err( 4216): at android.support.v7.app.AppCompatDelegateImplV9.setContentView(AppCompatDelegateImplV9.java:287)
W/System.err( 4216): at android.support.v7.app.AppCompatActivity.setContentView(AppCompatActivity.java:139)
W/System.err( 4216): at com.scorelab.kute.kute.Activity.RegisterActivity.onCreate(RegisterActivity.java:156)
W/System.err( 4216): at android.app.Activity.performCreate(Activity.java:5242)
W/System.err( 4216): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
W/System.err( 4216): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2164)
W/System.err( 4216): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2249)
W/System.err( 4216): at android.app.ActivityThread.access$800(ActivityThread.java:141)
W/System.err( 4216): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1212)
W/System.err( 4216): at android.os.Handler.dispatchMessage(Handler.java:102)
W/System.err( 4216): at android.os.Looper.loop(Looper.java:136)
W/System.err( 4216): at android.app.ActivityThread.main(ActivityThread.java:5052)
W/System.err( 4216): at java.lang.reflect.Method.invokeNative(Native Method)
W/System.err( 4216): at java.lang.reflect.Method.invoke(Method.java:515)
W/System.err( 4216): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:796)
W/System.err( 4216): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:612)
W/System.err( 4216): at dalvik.system.NativeStart.main(Native Method)
W/System.err( 4216): Caused by: java.lang.reflect.InvocationTargetException
W/System.err( 4216): at java.lang.reflect.Constructor.constructNative(Native Method)
W/System.err( 4216): at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
W/System.err( 4216): at android.view.LayoutInflater.createView(LayoutInflater.java:597)
W/System.err( 4216): ... 23 more
W/System.err( 4216): Caused by: java.lang.OutOfMemoryError
W/System.err( 4216): at android.graphics.BitmapFactory.nativeDecodeAsset(Native Method)
W/System.err( 4216): at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:601)
W/System.err( 4216): at android.graphics.BitmapFactory.decodeResourceStream(BitmapFactory.java:434)
W/System.err( 4216): at android.graphics.BitmapFactory.decodeResource(BitmapFactory.java:457)
W/System.err( 4216): at android.graphics.BitmapFactory.decodeResource(BitmapFactory.java:489)
W/System.err( 4216): at android.graphics.drawable.BitmapDrawable.inflate(BitmapDrawable.java:572)
W/System.err( 4216): at android.graphics.drawable.Drawable.createFromXmlInner(Drawable.java:939)
W/System.err( 4216): at android.graphics.drawable.Drawable.createFromXml(Drawable.java:879)
W/System.err( 4216): at android.content.res.Resources.createFromXml(Resources.java:2515)
W/System.err( 4216): at android.content.res.Resources.loadDrawable(Resources.java:2135)
W/System.err( 4216): at android.content.res.MiuiResources.loadDrawable(MiuiResources.java:393)
W/System.err( 4216): at android.content.res.Resources.loadDrawable(Resources.java:2062)
W/System.err( 4216): at android.content.res.TypedArray.getDrawable(TypedArray.java:602)
W/System.err( 4216): at android.view.View.(View.java:3558)
W/System.err( 4216): at android.view.View.(View.java:3488)
W/System.err( 4216): at android.view.ViewGroup.(ViewGroup.java:464)
W/System.err( 4216): at android.widget.RelativeLayout.(RelativeLayout.java:236)
W/System.err( 4216): ... 26 more
W/System.err( 4216): java.lang.NullPointerException
W/System.err( 4216): at com.scorelab.kute.kute.Activity.RegisterActivity.onCreate(RegisterActivity.java:298)
W/System.err( 4216): at android.app.Activity.performCreate(Activity.java:5242)
W/System.err( 4216): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
W/System.err( 4216): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2164)
W/System.err( 4216): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2249)
W/System.err( 4216): at android.app.ActivityThread.access$800(ActivityThread.java:141)
W/System.err( 4216): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1212)
W/System.err( 4216): at android.os.Handler.dispatchMessage(Handler.java:102)
W/System.err( 4216): at android.os.Looper.loop(Looper.java:136)
W/System.err( 4216): at android.app.ActivityThread.main(ActivityThread.java:5052)
W/System.err( 4216): at java.lang.reflect.Method.invokeNative(Native Method)
W/System.err( 4216): at java.lang.reflect.Method.invoke(Method.java:515)
W/System.err( 4216): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:796)
W/System.err( 4216): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:612)
W/System.err( 4216): at dalvik.system.NativeStart.main(Native Method)

Hey There!!
Hope you are doing well.

The technologies I identified in the project that should be used to generate the .gitignore are Java, macOS, Gradle, Android, IntelliJ.

Warm Regards
Vanshika Dhull

May be sign-in method Email/Password from firebase authentication console is not enabled?

Design 'Kute app' logo

THIS IS A NOT A REAL ISSUE BUT A PLACEHOLDER.

All the practicing PRs for Google Code-In 2017 should refer this issue. PRs referring this issue will be closed without merging. Do not refer this issue if you are NOT submitting a practice PR and need your work merged.

Issue

The image request call made to fetch images from URL is deprecated. Picasso is a library specialized in image fetching compared to Volley. We can integrate that library instead of Volley as volley hasn't been use anywhere in the app except for image fetching

Steps to reproduce

1. Go to RegisterActivity class
2. Find "ImageRequest"

Would you like to work on this issue?

Yes and I can send a PR for review!

It will be more easier for beginners to understand and contribute to the project if there is a template for Pull Requests.

Hi,
I got this error once I ran the app
java.lang.RuntimeException: Unable to get provider com.google.firebase.provider.FirebaseInitProvider: java.lang.ClassNotFoundException: com.google.firebase.provider.FirebaseInitProvider

Complete splash activity

The map in the app should have the option to either zoom out or zoom in the map. Also, there should be a compass(as an enhancement) in the right hand corner of the screen. These can be resolved by using the following in the LandActivity.java file.

UiSettings.setZoomControlsEnabled(true)
UiSettings.setCompassEnabled(boolean)

Hi!
I want to report a issue.
Splash activity is still active after intent to another activity.
It's so annoying and unusual.

Complete SignIn activity

Issue

When a user clicks sign out from the menu, he will be directed to the login page. But when we open the app again, we can directly go to map activity without sign in.

Steps to reproduce

1. Open app
2. Choose Signout from the menu
3. Close the app
4. Open app again

Hi!

There is two same function in one file. So, I commented the line for 1 function. And copy 1 line that's really important.
Before :

After :

Updating strings.xml file with facebook app id and google maps api key should be added to the documentation

Problem:
The Share and Send feature from the navigation drawer are currently not working

Steps to reproduce the problem:

1. Click on the hamburger icon (to open the navigation drawer)
2. Click on the send / share option

Nothing happens when you click either of these two options...

Would you like to work on this issue?
Yes and I can send a PR for review!

After correctly sign in with firebase user, the app redirect user to splash activity again and again from login activity.

The install instructions provided in the README file don't elaborate enough on the gradle set-up for the app, and so when i open it in android studio (by choosing to import project from external model, selecting gradle, and specifying the location gradle is installed) it refuses to compile stating:

Error:FAILURE: Build failed with an exception.

• What went wrong:
  Task 'assemble' not found in root project 'kute'.

• Try:
  Run gradle tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

• Get more help at https://help.gradle.org

BUILD FAILED in 0s

could you please add the entire set-up procedure to the README file to installation easier.

Issue

When the app opens, it's convenient for the user to have the map moved to his current location!

Steps to reproduce

1. Open app
2. Login using valid credentials
3. View the map

Would you like to work on this issue?

Yes and I'll send a PR for review!

Issue

The App Crashes as soon as we successfully authenticate a new user via google

Cause

This Crash is caused due to the image assignment to an Image View that might have existed previously but is non existent now

Steps to reproduce

Open app
Sign in through google after setting up authentication through google via firebase

Would you like to work on this issue?

Yes and I can send a PR for review!

Missing contributing.md

Issue Overview

It is generally a good practice to include the contribution guide along with the project. In this project no contribution guide is present and so it becomes difficult to contribute to the community.

Issue Explanation (Background, Importance, etc.)

It would be better to add the contribution guide to the project. Although the guides are present at the central repository, people wishing to do minor contributions might not go through the pain of searching for the contribution guide. I am not sure if this is a good idea but I felt that this is something that is required.

Are you interested to work on it?

Yes

Issue
Contains an extra java file SplashActivity in kute/views which has many unresolved errors that do not allow gradle build to complete

Solution
There is already one SplashActivity in kute/kute which is the correct file used in the app thus we can delete the above mentioned file

There are no strings facebook_app_id and googleMapsApi in the values folder as a result of which the gradle does not build

Feature:

Instead of an activity of task selection,implemented a FAB menu which can enhance user experience

Implementation

Can submit a PR for review

Snapshots:

I am trying o login with Facebook and i have also added the Facebook app id. but still i am facing problems to log in.