sclu1034 / express-knex-transaction Goto Github PK

The middleware calls trx.commit() in onFinished handler. Therefore after the response is sent to the client. So in case DB commit is slower than the client connection, the client may receive the response before it is actually commited to DB.

Imagine a POST request that inserts an item to DB followed imediatelly with a GET request that tries to select the created item. If the client is fast enough, the GET request may be performed before the original commit finishes. So it won't find the inserted item in DB yet because of the race condition.

Instead the server should wait for trx.commit() to finish and only then it should send the response to the client.

Note that changing onFinished handler to onHeader or something similar won't help, as trx.commit() is async and the response won't wait until the commit finishes.