LHCb style and duplication about mplhep HOT 9 CLOSED

@graipher contributed it. The duplication Is intentional, but I don't think anyone actually copies the mplstyle files so I should get rid of them

from mplhep.

To clarify, I'm not part of LHCb so I'm not qualified to say how it should look, but if you think it could be improved a PR is welcome.

from mplhep.

The mplstyle file is just what I created the Python file from. It is an unofficial style file that was floating around in the LHCb collaboration when I was a member, as you can see by the list of contributors in that file. I do not claim that it is either official nor exactly like the official plotting style used by LHCb when plotting with ROOT. However, I think it is close. It has worked for me and others in my group. Note though, that it has not been updated in a couple of years, apart from some minor modifications I made, so if you are aware of a more official or correct one, please contribute it if possible.

I'm actually not sure which setting the markers come from when using plot, but you can always use plt.plot(x, y, '-') to not show them. It might be from the custom axes.prop_cycle, which I added to the file, so try removing the marker cycler.

The font size is large on purpose, in order to be readable in two-column papers and presentations. The figure size is increased in order to somewhat compensate for it.

from mplhep.

I see, and I am also aware of the floating style-file.

Why is the prop_cycle chosen not to have - anymore? for dotted plots, assuming they're the default?

Is there any way to make this more "official"?

It's very useful btw, thanks a lot!

from mplhep.

@mayou36 As I said, if you would like it to change please submit a PR or at least a list of desired changes, I can sort it out then.

If these changes would be substantial and could interfere with other peoples preferences, we can easily have two styles.

from mplhep.

Closing this for inactivity

from mplhep.

Coming back to this, how do you see to get a second style added? In the Python file, not in the mplstyle? I'll start a PR then.

from mplhep.

The "txt" stylesheets are deprecated. Just add a new dict like this one https://github.com/scikit-hep/mplhep/blob/master/src/mplhep/styles/lhcb.py#L19. If there's no better name, it can be LHCbv2

EDIT: Actually the mplstyle files were deprecated and now they are just removed. Thanks to recent PR from @matthewfeickert you can even get a similar API -> hep.set_style("LHCb")

from mplhep.

@mayou36 Thanks a lot for the PR, the changes should be out in 0.2.8

from mplhep.