FieldMaskUtil.applyMask exists as a useful tool to fi

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

More efficient one if Java classes are generated: <div class="highlight highlight-

FieldMaskUtil.merge support about scalapb HOT 4 CLOSED

jroper commented on May 24, 2024 1

FieldMaskUtil.merge support

from scalapb.

Comments (4)

jroper commented on May 24, 2024 1

I may, I'll see about time. I mainly created the issue to save others the time from working out whether it exists or not. As an inefficient work around, this works:

import com.google.protobuf.DynamicMessage
import com.google.protobuf.field_mask.FieldMask
import com.google.protobuf.util.FieldMaskUtil
import scalapb.{ GeneratedMessage, GeneratedMessageCompanion }

object UpdateMaskSupport {

  def merge[T <: GeneratedMessage](source: T, destination: T, fieldMask: FieldMask)(implicit
      companion: GeneratedMessageCompanion[T]
  ): T = {
    val sourceBytes = source.toByteString
    val destBytes   = destination.toByteString

    val sourceJava      = DynamicMessage.parseFrom(companion.javaDescriptor, sourceBytes)
    val destJavaBuilder = DynamicMessage.parseFrom(companion.javaDescriptor, destBytes).toBuilder
    FieldMaskUtil.merge(FieldMask.toJavaProto(fieldMask), sourceJava, destJavaBuilder)
    companion.parseFrom(destJavaBuilder.build().toByteString.newCodedInput())
  }
}

A more efficient solution exists if you're happy also generating Java protobuf classes, but the above works without Java protobuf classes generated.

from scalapb.

thesamet commented on May 24, 2024

Hey @jroper , thanks for making this feature request. Will you be able to work on a PR?

from scalapb.

jroper commented on May 24, 2024

More efficient one if Java classes are generated:

import com.google.protobuf.field_mask.FieldMask
import com.google.protobuf.util.FieldMaskUtil
import scalapb.{GeneratedMessage, GeneratedMessageCompanion, JavaProtoSupport}

object UpdateMaskSupport {

  def merge[T <: GeneratedMessage, J <: com.google.protobuf.GeneratedMessage](fieldMask: FieldMask, source: T, destination: T)(implicit
      companion: GeneratedMessageCompanion[T] with JavaProtoSupport[T, J]
  ): T = {
    val sourceJava      = companion.toJavaProto(source)
    val destJavaBuilder = companion.toJavaProto(destination).toBuilder
    FieldMaskUtil.merge(FieldMask.toJavaProto(fieldMask), sourceJava, destJavaBuilder)
    companion.fromJavaProto(destJavaBuilder.build().asInstanceOf[J])
  }
}