Comments (6)
This is an example graph which gives the wrong answer:
https://github.com/garycoady/scala-graph/commit/dc3f3ed0b2b63c41615aad2ecbd92af5f93bc508
from scala-graph.
On larger graphs, just adding nodes to the priority queue with the correct weight causes a crippling slowdown for me (but at least it's giving the right answer). Probably because the same node may be added to the priority queue potentially many times. What is really wanted is a way of updating the ordering of the queue as the tentative distance of a node changes, like what is described in http://algorithms.soc.srcf.net/notes/dijkstra_with_heaps.pdf
from scala-graph.
Hi Gary, thanks for reporting and even providing a test and the accompanying fix! Would you mind creating a pull request later on?
from scala-graph.
No problem! I've opened a pull request (now that I understand the problem, there's a better test case included).
from scala-graph.
It seems we can close this issue due to your fix documented in #10. Any objectives?
from scala-graph.
I think it's fixed, thanks for reviewing/accepting the changes!
from scala-graph.
Related Issues (20)
- 1.13.x versions not released correctly HOT 3
- Immutable Graph nodes should be covariant HOT 2
- Insertions are not in constant time HOT 5
- Does scalagraph have the notion of a sourced graph? HOT 3
- Adding code for graph layout HOT 6
- Scala.js 1.1.0 support HOT 1
- Problem when trying to convert JSON to a Graph HOT 7
- Weird behaviour for diSuccessors, diPredecessors and isDirectPredecessorOf when node is connected to himself. HOT 3
- Constrained User Guide example is not reproducible HOT 3
- Wrong Operations in EqSetFacade HOT 1
- Finding all paths in a graph from node A to node B HOT 2
- Open issues for 2.x HOT 7
- Switch from Travis CI to Github Actions HOT 4
- Enable Scala-Steward on this project HOT 2
- Double (1.0) node is unexpectedly considered as self-successor HOT 9
- type inference not working for .toOuter; Scala 3, scala-graph 1.13.2 HOT 3
- Traversing mutable graphs in multi-thread HOT 4
- Topological sort may not return a node in a cycle when it fails HOT 1
- No potential Scala-Native release?
- Documentation issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-graph.