Code Monkey home page Code Monkey logo

Comments (6)

fiadliel avatar fiadliel commented on June 25, 2024

This is an example graph which gives the wrong answer:
https://github.com/garycoady/scala-graph/commit/dc3f3ed0b2b63c41615aad2ecbd92af5f93bc508

from scala-graph.

fiadliel avatar fiadliel commented on June 25, 2024

On larger graphs, just adding nodes to the priority queue with the correct weight causes a crippling slowdown for me (but at least it's giving the right answer). Probably because the same node may be added to the priority queue potentially many times. What is really wanted is a way of updating the ordering of the queue as the tentative distance of a node changes, like what is described in http://algorithms.soc.srcf.net/notes/dijkstra_with_heaps.pdf

from scala-graph.

peter-empen avatar peter-empen commented on June 25, 2024

Hi Gary, thanks for reporting and even providing a test and the accompanying fix! Would you mind creating a pull request later on?

from scala-graph.

fiadliel avatar fiadliel commented on June 25, 2024

No problem! I've opened a pull request (now that I understand the problem, there's a better test case included).

from scala-graph.

peter-empen avatar peter-empen commented on June 25, 2024

It seems we can close this issue due to your fix documented in #10. Any objectives?

from scala-graph.

fiadliel avatar fiadliel commented on June 25, 2024

I think it's fixed, thanks for reviewing/accepting the changes!

from scala-graph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.