Open issues for 2.x about scala-graph HOT 7 OPEN

FYI I'm working on "2. Drop Scala 2.12 compatibility" now.

from scala-graph.

It would be great if you found time to work on the unfinished parts. Some suggestions:

1. Just care about core first.
2. Drop Scala 2.12 compatibility by also merging back 2.13-specific folders and dropping compatibility helper types.
3. Rename State.scala- back to State.scala and make it compile. Refactor the accompanying test. To test State in isolation may require some more sophisticated test setup, though.
4. Rename GraphTraversal.scala- back to GraphTraversal.scala and make it compile. For the missing pieces try using ??? temporarily.
5. Continue with GraphTraversalImpl.scala- and TraverserImpl.scala-.
6. Once traversing sources compile, rename accompanying test sources back to Scala source files and refactor tests.

At this point you are almost done and, having bocome a Graph4Scala expert, you are able to continue on your own. 😄

from scala-graph.

Unfortunately, core is half done. I renamed test source files because they were in way when refactoring step by step: https://github.com/scala-graph/scala-graph/tree/2.x/core/src/test/scala/scalax/collection. Notably the traversing part is still missing.

from scala-graph.

@peter-empen if I find some time to look into this, are there any pointers you can give on how to proceed with traversing or how you would like the API / implementation to look like?

from scala-graph.

Hi @peter-empen,

I gave this a shot yesterday. Unfortunately, State can't be made to compile without the other classes because it has a this: GraphTraversalImpl.
I went down the rabit hole and renamed the other required .scala- files to .scala, but now I've got ~570 compile errors, each of which currently takes me ~10 minutes to understand and fix.
It would probably get better with time, but still exceed the time I can invest by far...
Not sure how to proceed here...

from scala-graph.

Hi Martin,
Thank you for looking into this. Yeah, it's a real challenge. Sorry, I should have warned you before 😄. Let me give it a try in the following days...

from scala-graph.

I re-added a bunch of functionality in 53e0a65 but there is still much to do. From the above points, # 6 is missing but that's not all by far...

from scala-graph.