Comments (3)
peter-empen
commented on September 27, 2024
The function throwing the above exception is responsible for converting from DotAttr names and values of type String to a DOT ID. Since DOT IDs mustn't be empty, to throw an exception here is ok in my understanding. Thus this benavior has been intentional.
However, it appears like an internal bug. To avoid this misunderstanding, the export could throw a more verbose exception at the same place. Or we could add asserts to case class DotAttr to assure non-empty arguments.
Which of the above would you prefer? Do you have any other suggestions?
from scala-graph.
kscaldef
commented on September 27, 2024
It seems like it would be clearer to add an assert into DotAttr
from scala-graph.
peter-empen
commented on September 27, 2024
Asserts included in release 1.7.3.
from scala-graph.
Related Issues (20)
- Insertions are not in constant time HOT 5
- Does scalagraph have the notion of a sourced graph? HOT 3
- Adding code for graph layout HOT 6
- Scala.js 1.1.0 support HOT 1
- Problem when trying to convert JSON to a Graph HOT 7
- Weird behaviour for diSuccessors, diPredecessors and isDirectPredecessorOf when node is connected to himself. HOT 3
- Constrained User Guide example is not reproducible HOT 3
- Wrong Operations in EqSetFacade HOT 1
- Finding all paths in a graph from node A to node B HOT 2
- Open issues for 2.x HOT 7
- Switch from Travis CI to Github Actions HOT 4
- Enable Scala-Steward on this project HOT 2
- Double (1.0) node is unexpectedly considered as self-successor HOT 9
- type inference not working for .toOuter; Scala 3, scala-graph 1.13.2 HOT 3
- Traversing mutable graphs in multi-thread HOT 4
- Topological sort may not return a node in a cycle when it fails HOT 1
- No potential Scala-Native release? HOT 2
- Documentation issue HOT 1
- persistent data structure HOT 1
- Can't extend Edges in case class in scala 3 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-graph.