Code Monkey home page Code Monkey logo

carousel-slider's People

Contributors

dependabot[bot] avatar elhaus avatar sayful1 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

carousel-slider's Issues

Feature: Center slider item

When using images with different sizes (which works great so far), the movement always aligns the “active” image to the left. It would be great if the active image could be aligned to the center of the browser. This would be great for presenting photos that are a mix of landscape and portrait orientations.

I’ve seen that this option was requested in the past already. I hope you can find some time to tackle this.

BUG: Recent Versions NOT Rendering HTML

We are using HTML tags in the product titles and some post titles. Earlier versions of Carousel Slider plugin was working just fine, they are rendering the HTML tags, but when updated to later versions, specifically the 2.2.0 all HTML tags in title are not rendered anymore and therefor show tags.

The HTML tags are used for purpose and cannot be removed.

Any solution to this?

Bug Store XSS with profile image

Hi sayful1,
I discovered a Store XSS bug on your plugin. In the information section of the image, I inserted the XSS payload and took the shortcode of the photo slide and inserted a new post with public status.
https://i.imgur.com/f1R0YcD.png

I view the post and trigger xss
https://i.imgur.com/e3ahiUT.png

The whole process I do with author accounts.

TypeError - Can anyone help solve this?

Slide content not rendering in version 2.2.0

Hi,

First, thanks for a useful plugin.

There is an issue in the 2.2.0 version. None of the slide content and the slide links rendered to the screen, and the slide only shows the slide background image. There were no errors in the browsers console log.

I resolved the issue by rolling back to version 2.1.0

Best!

titles and order by

Hi, I have a couple of questions,

1 – Is there any way I can change my posts titles from h2 to h3?
2 – Can I order by the date the post was published, rather than the date it was modified? The date on my carousel is showing the modified date rather than the published date…

Thanks, hope you can help

The page I need help with:
http://gloucesterwebdesign.co.uk/reallyhelpfulmarketing/carousel/

Uncaught TypeError: this._addClass is not a function

I just update to the new version and got that message also button add gallery not working.

jquery.min.js?ver=3.5.1:2 Uncaught TypeError: this._addClass is not a function
    at e.<computed>.<computed>._create (sortable.min.js?ver=1.12.1:9)
    at e.<computed>.<computed>._create (utils.min.js?ver=3.0.7:6)
    at e.<computed>.<computed>._createWidget (utils.min.js?ver=3.0.7:6)
    at new e.<computed>.<computed> (utils.min.js?ver=3.0.7:6)
    at HTMLDivElement.<anonymous> (utils.min.js?ver=3.0.7:6)
    at Function.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.e.fn.<computed> [as sortable] (utils.min.js?ver=3.0.7:6)
    at Object.init (postbox.min.js?ver=5.6:2)
    at Object.add_postbox_toggles (postbox.min.js?ver=5.6:2)
jquery.min.js?ver=3.5.1:2 Uncaught TypeError: this._addClass is not a function
    at e.<computed>.<computed>._create (slider.min.js?ver=1.12.1:9)
    at e.<computed>.<computed>._create (utils.min.js?ver=3.0.7:6)
    at e.<computed>.<computed>._createWidget (utils.min.js?ver=3.0.7:6)
    at new e.<computed>.<computed> (utils.min.js?ver=3.0.7:6)
    at HTMLDivElement.<anonymous> (utils.min.js?ver=3.0.7:6)
    at Function.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.e.fn.<computed> [as slider] (utils.min.js?ver=3.0.7:6)
    at e.<computed>.<computed>._initControls (iris.min.js?ver=1.0.7:5)
    at e.<computed>.<computed>.x.isFunction.r.<computed> [as _initControls] (core.min.js?ver=1.12.1:116)
Uncaught TypeError: this._addClass is not a function
    at e.<computed>.<computed>._create (sortable.min.js?ver=1.12.1:9)
    at e.<computed>.<computed>._create (utils.min.js?ver=3.0.7:6)
    at e.<computed>.<computed>._createWidget (utils.min.js?ver=3.0.7:6)
    at new e.<computed>.<computed> (utils.min.js?ver=3.0.7:6)
    at HTMLUListElement.<anonymous> (utils.min.js?ver=3.0.7:6)
    at Function.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.each (jquery.min.js?ver=3.5.1:2)
    at s.fn.init.e.fn.<computed> [as sortable] (utils.min.js?ver=3.0.7:6)
    at initSortable (media-views.min.js?ver=5.6:2)
    at initialize (media-views.min.js?ver=5.6:2)

Need to change the header tags in post carousels

The post sliders all use h1 tags for the post titles. If you’ve got 10 slides on a page, that creates a problem for SEO. Good SEO demands only one h1 per page. The slide titles have to be change to h3 or h4.

I edited the plug-in template files on my installation, but this needs to be done by the developer.

Additional Security Issues Related to Issue Addressed in Version 2.2.3

While reviewing the security change made in version 2.2.3, as at least one of our customers is using the plugin, we noticed that there are still a couple of AJAX accessible functions that are lacking a capabilities check and or a nonce check. The function add_slide_template() in the file /modules/HeroCarousel/Ajax.php lacks both, leading to a vulnerability. The function deactivate_feedback() in the file /includes/Admin/Feedback.php is lacking a capabilities check.

Video Content isnt saved

Dear @sayful1 , thank you for this plugin. We encountered not being able to save video urls in the content field. There is a bug in the Module.php.
Original

 <textarea class="sp-input-textarea" id="_video_url" cols="35" rows="6"
	name="_video_url"><?php echo esc_textarea( $urls ); ?></textarea>

Our version:

<!--- change by indy -->
<textarea class="sp-input-textarea" id="_video_url" cols="35" rows="6" 
	name="carousel_slider[_video_url]"><?php echo esc_textarea( $urls ); ?></textarea>

Best, c--

Feature : random order for images carousel

Thanks a lot for all your work ! Most customizable carousel I found so far.

But I think a feature is missing : shuffle images order.

I did it for my website by modifying your plugin. In template\public\images-carousel.php I added shuffle($images_ids); just before your foreach ( $images_ids as $image_id ):

I think it will be cool to enable it as a parameter of your carousel.

Thanks again for your work

Feature: Slider item equal height

The title of the products vary in length, when is short it appears on one line, if it is longer it appears on two lines, this makes the whole product boxes with different heights.

Is there anyway to make the height the same for all of them, so that the prices are aligned with each other and the buttons aligned with each other?

If you add as a feature, this would be wonderful, but if you could provide a PHP code or CSS code that fixes this, this would even be much better and appreciated.

https://wordpress.org/support/topic/slider-height-25/

Carousel slider showing hidden products

I have been using your plugin for a while and love it.

How can I stop the Carousel Slider showing hidden products. We have products "hidden" in Woocommerce, therefore shouldn't be showing in the slider at all when we choose a Category.

How can we fix this urgently ?

This is a bit of an issue, unless I have a setting incorrect maybe ?

Or do I have to do some CSS coding to fix it ?

Thanks in advance.
Thanks
Kristin

Topic Link: https://wordpress.org/support/topic/carousel-slider-showing-hidden-products/

Feature: add possibility to sort posts by publication date

Hi @sayful1,
thank you very much for this great plugin.

I would like to ask you to add the possibility to sort posts by publication date.

I have already prepared the code for this
/modules/PostCarousel/Admin.php - line 161

array(
	'id'      => '_post_orderby',
	'name'    => esc_html__( 'Order by', 'carousel-slider' ),
	'std'     => 'ID',
	'options' => array(
		'none'          => esc_html__( 'No order', 'carousel-slider' ),
		'ID'            => esc_html__( 'Post id', 'carousel-slider' ),
		'author'        => esc_html__( 'Post author', 'carousel-slider' ),
		'title'         => esc_html__( 'Post title', 'carousel-slider' ),
		'modified'      => esc_html__( 'Last modified date', 'carousel-slider' ),
		'date'          => esc_html__( 'Publication date', 'carousel-slider' ),           // Added this line
		'rand'          => esc_html__( 'Random order', 'carousel-slider' ),
		'comment_count' => esc_html__( 'Number of comments', 'carousel-slider' ),
	),
)

ArgumentCountError

Plugin version: 2.1.0
WooCommerce version: 6.9.2
WordPress version: 6.0.2
PHP version: 7.4
Astra theme version: 3.9.2

I have made a Product Carousel and when we enable the “Show Sale Tag” on the slider we get the next error on our website and in the log files.

2022-10-02T07:27:16+00:00 CRITICAL Uncaught ArgumentCountError: Too few arguments to function Astra_Woocommerce::sale_flash(), 2 passed in /test.be/wp-includes/class-wp-hook.php on line 307 and exactly 3 expected in /test.be/wp-content/themes/astra/inc/compatibility/woocommerce/class-astra-woocommerce.php:302
Stack trace:
#0 /test.be/wp-includes/class-wp-hook.php(307): Astra_Woocommerce->sale_flash('<span class="on...', Object(WC_Product_Simple))
#1 /test.be/wp-includes/plugin.php(191): WP_Hook->apply_filters('<span class="on...', Array)
#2 /test.be/wp-content/plugins/carousel-slider/modules/ProductCarousel/View.php(173): apply_filters('woocommerce_sal...', '<span class="on...', Object(WC_Product_Simple))
#3 /test.be/wp-content/plugins/carousel-slider/modules/ProductCarousel/View.php(117): Carous in /test.be/wp-content/themes/astra/inc/compatibility/woocommerce/class-astra-woocommerce.php op de lijn 302

Constant carlousel speed

Is it possible to have the carousel move with a constant speend without stopping after each "step"?
See the carousel with the company banners here: https://uat.kosbasket.at. I would like them to have constant speed.
Thanks

Slide is streched or centred to the right when doing F5

I think the carousel is awesome but I’m having an issue with it displaying properly when a browser visits the site before the images in the carousel are cached. Or if I reload the page without using cached content. The images show up but the carousel is completely vertical and displays only half of an image or spans multiple rows. In the webpage I shared this carousel is the 4th one down.

It does this on every modern browser that I’ve tested and on multiple operating systems.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.