saul-jb / blockstack-sso Goto Github PK

I think it might be better ti use a classn name like BlockstackCommon or something for this one so that it's clear when working on specific instances that you're working with the class than's common to all the php apps in the environment and not a class specific to e.g. mediawiki.

Also best stick with convention and use CamelCase for the classname not an underscore.

The readme is currently using old file names, it needs updating to the current ones to avoid confusion.

I tried build a simple php login page with blockstack on my local computer, my environment is XAMPP.But, after I git clone the blockstack-sso, I cannot find blockstack_sso.min.js . Where is this js file?

and I also cannot find the blockstack_sso.php in the blockstack-sso folder. What should I do?

It looks like on line 7 of blockstack-common.js that you're setting the blockstack service url to default to the web based blockstack browser... shouldn't the default behaviour be to connect to the running local service and fallback on the web-based one only if it's not there?

Also the method parameters should be covered in the docs, it only shows it as having no parameters.

Tokens are decoded on the client-side and then sent to the server using AJAX. The server-side never verifies the signature and accepts any input. It allows you to potentially impersonate other users.

See https://github.com/MarvinJanssen/blockstack-auth for signature verification.