Comments (6)
I wonder if it is a good idea to use /proc
whenever it is available. Solution is up in #5 that should work on both Linux and Cygwin, but I wonder if it would break systems such as FreeBSD. Do they all have compatible /proc
? I’ll need to find out.
from shellingham.
It looks like the BSD4.4 children use /proc/$PID/status
instead of /proc/$PID/stat
.
Maybe write the module to:
try:
proc()
except:
ps()
from shellingham.
Urrgh! Yeah I guess I need to revise the logic. A try-except is a good idea (but probably not a bare one).
from shellingham.
Just handle the different structures of proc
. There are only like 3 filesystems. It’s a finite space.
from shellingham.
Okay I think we have two. What’s the third /facepalm
from shellingham.
I decided to
- Try /proc (detect if it is Linux and BSD styles)
- If that fails, try ps
- If ps also fails, raise an error
We can add compatibility to more uncommon formats when someone actually wants them.
from shellingham.
Related Issues (20)
- Can we correctly detect the full path of the shell for windows? HOT 3
- Officially support Python 3.7+ HOT 3
- WinError using pipenv in Pypy HOT 1
- Shell detection failure inside docker image on ARM Macbook HOT 10
- New release HOT 6
- [1.5.0] Incorrectly List by Pypi as Available for Python < 3.7 HOT 1
- [1.5.0] Please Yank 1.5.0 and Release 1.5.1 for Limit package installation to Python >= 3.7 HOT 2
- Doesn't detect powershell on win32 HOT 5
- doesn't detect bash on win32 HOT 7
- [Question] Are you open to adding type annotations? HOT 3
- sdist is missing tests HOT 1
- Fails to detect shell in docker containers run with rosetta on Apple Silicon HOT 1
- error with shellingham HOT 1
- ShellDetectionFailure for zsh HOT 10
- unsupported proc format HOT 6
- tests/test_posix.py::test_get_shell[mapping0-result0] fails with 1.5.2+ HOT 1
- Always detects fish
- Configure Pypi trusted publishing pipeline HOT 1
- Dash prefix does not always imply login shell HOT 1
- Failure to resolve sh -c bash HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shellingham.