Comments (5)
I've dug into this a bit more... I'm using pyenv which has a shim that wraps the call to python in a .bat script which uses cmd.exe.
For nt shells it may be better to not stop at the first shell you see, but to use the last shell in the stack, at least if you're looking for the interactive shell, maybe there should be a detect_interactive_shell(), the uses cases I'm looking at are poetry env shell and pipenv shell...
>>> import psutil
>>> import os
>>> proc = psutil.Process()
>>> parent_1 = psutil.Process(proc.ppid())
>>> parent_1
psutil.Process(pid=25652, name='cmd.exe', status='running', started='08:43:04')
>>> parent_2 = psutil.Process(parent_1.ppid())
>>> parent_2
psutil.Process(pid=3680, name='powershell.exe', status='running', started='07:37:02')
>>> parent_3 = psutil.Process(parent_2.ppid())
>>> parent_3
psutil.Process(pid=3664, name='WindowsTerminal.exe', status='running', started='07:36:59')
>>> parent_4 = psutil.Process(parent_3.ppid())
>>> parent_4
psutil.Process(pid=23448, name='explorer.exe', status='running', started='2022-11-11 08:00:07')
from shellingham.
I would categorise this as a bug in pyenv-win. They should not use Batch files for shims. Shims should be exe.
from shellingham.
@uranusjr while I agree and find pyenv-win's shims and rehash are annoying, I'm not sure that it is possible with an exe. Do you know of an exe shim example you can point me to, maybe I can contribute some time to working on that.
from shellingham.
From pyenv-win’s issue tracker pyenv-win/pyenv-win#352
Scoop also has a shim implementation that I personally like a lot, although it being in C# is probably a hurdle for a project adding a compilation step (I don’t think pyenv-win currently has any such dependencies).
from shellingham.
@uranusjr thanks!!
from shellingham.
Related Issues (20)
- Can we correctly detect the full path of the shell for windows? HOT 3
- Officially support Python 3.7+ HOT 3
- WinError using pipenv in Pypy HOT 1
- Shell detection failure inside docker image on ARM Macbook HOT 10
- New release HOT 6
- [1.5.0] Incorrectly List by Pypi as Available for Python < 3.7 HOT 1
- [1.5.0] Please Yank 1.5.0 and Release 1.5.1 for Limit package installation to Python >= 3.7 HOT 2
- doesn't detect bash on win32 HOT 7
- [Question] Are you open to adding type annotations? HOT 3
- sdist is missing tests HOT 1
- Fails to detect shell in docker containers run with rosetta on Apple Silicon HOT 1
- error with shellingham HOT 1
- ShellDetectionFailure for zsh HOT 10
- unsupported proc format HOT 6
- tests/test_posix.py::test_get_shell[mapping0-result0] fails with 1.5.2+ HOT 1
- Always detects fish
- Configure Pypi trusted publishing pipeline HOT 1
- Dash prefix does not always imply login shell HOT 1
- Failure to resolve sh -c bash HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shellingham.