Code Monkey home page Code Monkey logo

mangachecks's Introduction

Sobre mim

Languages and Tools:
Figma Swift Git JavaScript TypeScript Visual Studio Code

Social Medias:

mangachecks's People

Contributors

sarahmadalena avatar

Stargazers

avatar avatar avatar

Watchers

avatar

mangachecks's Issues

Oi Sarah, parabéns pelo projeto! Sei que você se dedicou muito a ele.

Eu percebi que as constraints dos seus elementos estão todas juntas em um único lugar, dessa forma:

MangaChecks/View/MangaTableViewCell.swift

Lines 58 to 87 in 29dabd0

override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
super.init(style: style, reuseIdentifier: reuseIdentifier)
self.contentView.addSubview(profileImagesView)
containerView.addSubview(title)
containerView.addSubview(genresDetailedLabel)
self.containerView.addSubview(button)
self.contentView.addSubview(containerView)
profileImagesView.centerYAnchor.constraint(equalTo: self.contentView.centerYAnchor).isActive = true;
profileImagesView.leadingAnchor.constraint(equalTo: self.contentView.leadingAnchor, constant:10).isActive = true;
profileImagesView.widthAnchor.constraint(equalToConstant: 80).isActive = true;
profileImagesView.heightAnchor.constraint(equalToConstant: 80).isActive = true
containerView.centerYAnchor.constraint(equalTo: self.contentView.centerYAnchor).isActive = true;
containerView.leadingAnchor.constraint(equalTo: self.profileImagesView.trailingAnchor, constant: 10).isActive = true;
containerView.trailingAnchor.constraint(equalTo:self.contentView.trailingAnchor, constant: -10).isActive = true;
containerView.heightAnchor.constraint(equalToConstant: 80).isActive = true
title.topAnchor.constraint(equalTo: self.containerView.topAnchor).isActive = true;
title.leadingAnchor.constraint(equalTo: self.containerView.leadingAnchor).isActive = true;
title.trailingAnchor.constraint(equalTo: self.containerView.trailingAnchor).isActive = true
genresDetailedLabel.topAnchor.constraint(equalTo: self.title.bottomAnchor).isActive = true;
genresDetailedLabel.leadingAnchor.constraint(equalTo: self.containerView.leadingAnchor).isActive = true;
genresDetailedLabel.topAnchor.constraint(equalTo: self.title.bottomAnchor).isActive = true
button.widthAnchor.constraint(equalToConstant: 40).isActive = true
button.heightAnchor.constraint(equalToConstant: 40).isActive = true
button.trailingAnchor.constraint(equalTo: self.contentView.trailingAnchor, constant: -20).isActive = true
button.centerYAnchor.constraint(equalTo: self.contentView.centerYAnchor).isActive = true
}

O ideal seria colocar cada constraint em um função e fazendo apenas o chamado dela, assim o código fica mais limpo, organizado e consequentemente mais fácil de ler.

Aqui um exemplo de como poderia ficar:

func setConstrains(){
        NSLayoutConstraint.activate([
            button.widthAnchor.constraint(equalToConstant: 40).isActive = true 
           button.heightAnchor.constraint(equalToConstant: 40).isActive = true 
           button.trailingAnchor.constraint(equalTo: self.contentView.trailingAnchor, constant: -20).isActive = true 
           button.centerYAnchor.constraint(equalTo: self.contentView.centerYAnchor).isActive = true
        ])
 }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.