Code Monkey home page Code Monkey logo

Comments (2)

marcorosa avatar marcorosa commented on June 11, 2024

Hello @ManishYadav-SAP thanks for opening this issue.

The current HTTPS setting works when running docker containers, but it doesn't work when running directly the web server from terminal.
I test the code and take some note in this issue not to lose track.

from credential-digger.

marcorosa avatar marcorosa commented on June 11, 2024

Notes on the issue:

  1. the .env must list certificate and private key with a path relative to wsgi.py for running in the docker container (because the Dockerfile copies the content of ui into /credential-digger-ui so these files would be lost), whereas these paths must be relative to the project root when running from the terminal.
  2. when running from the terminal, we run directly ui/server.py, whereas the Dockerfile works with entry point run.sh, that runs wsgi:app using gunicorn (both in case of https enabled or not)

Ideas on possible fix:

  • the certificate and private key, if set, have to be copied from dockerfile (and not dropped directly with COPY . /credential-digger-ui)
  • if running with docker, then we can't use local (absolute or relative) paths because the certificates have to be copied in the container. Then, we need to override the env variables.
  • wsgi.py and server.py should be unified (only server.py should stay), if possible. Keeping both of them is confusing and hard to maintain (indeed, we lost track of this after 1 or 2 years)
  • if we only keep server.py, then we need to define a ssl_context and pass it to app.run or the app configs

Once we decide how to fix this issue, we need to update the instructions in the wiki accordingly.

from credential-digger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.