Code Monkey home page Code Monkey logo

open-stalk's Introduction

open-stalk's People

Contributors

brianmitchl avatar corinneling avatar jbmills327 avatar kalpanibhagya avatar marcowright avatar rahul-vijay avatar rowhitswami avatar sanudatta11 avatar sinashish avatar thilagavathi1 avatar vipulgupta2048 avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

open-stalk's Issues

Center a image using CSS

The current behavior of the image is it is aligned on the left side of the page.
Just center the image fetched after clicking on the Go! button ๐Ÿ˜Š

JS implementation improvement

  • Currently the apps does not check for invalid users or when the said PR is "empty"
  • To support more "data" available for the card UI, let's load the user and PR items separately.
  • Better Separation of Concern for javascript functions by separating which functions do "dom printing", "requesting data", or "manage callbacks"

[Enhancement] Shows only 4 pull request made

I recommend that the tool shows all the pull requests that were made in the month of October which are valid for Hacktoberfest 2017.
I understand that the tool does its job by showing only 4. But wouldn't it be better if you know your entire progress then just a small part of it.
Just a thought.

Use the correct way to determine a PR state

Currently, the code justify Closed PR as Merged.
This, however might not reflect the real state, as there are prerequisites that need to be fulfilled to get the "status" of a PR.
Please take a look at this API call

https://api.github.com/search/issues?q=-label:invalid+created:2017-03-22T00:00:00-12:00..2017-03-24T23:59:59-12:00+type:pr+is:public+author:Joshfindit&per_page=300

Results:

// 20171012083256
// https://api.github.com/search/issues?q=-label:invalid+created:2017-03-22T00:00:00-12:00..2017-03-24T23:59:59-12:00+type:pr+is:public+author:Joshfindit&per_page=300

{
  "total_count": 2,
  "incomplete_results": false,
  "items": [
    {
      "url": "https://api.github.com/repos/janaipakos/ghibliapi/issues/3",
      ...
      "id": 216229389,
      "number": 3,
      "title": "Convert IDs to v4 UUIDs",
      ...
      "state": "closed",
      "locked": false,
      "assignee": null,
      "comments": 1,
      "created_at": "2017-03-22T22:35:15Z",
      "updated_at": "2017-03-23T00:09:33Z",
      "closed_at": "2017-03-23T00:09:04Z",
      ...
    },
    {
      "url": "https://api.github.com/repos/janaipakos/ghibliapi/issues/2",
      ...
      "id": 216223281,
      "number": 2,
      "title": "Pluralize 'person' to 'people'",
      ...
      "state": "closed",
      "locked": false,
      "assignee": null,
      "assignees": [
        
      ],
      "milestone": null,
      "comments": 0,
      "created_at": "2017-03-22T22:06:23Z",
      "updated_at": "2017-03-22T22:35:38Z",
      "closed_at": "2017-03-22T22:35:33Z",
      ...
    }
  ]
}

Actually, for the issue janaipakos/ghibliapi#2, it is actually Closed and Not Merged

// 20171012084256
// https://api.github.com/repos/janaipakos/ghibliapi/pulls/2

{
  "url": "https://api.github.com/repos/janaipakos/ghibliapi/pulls/2",
  "id": 112121577,
  ...
  "number": 2,
  "state": "closed",
  ...
  "created_at": "2017-03-22T22:06:23Z",
  "updated_at": "2017-03-22T22:35:38Z",
  "closed_at": "2017-03-22T22:35:33Z",
  "merged_at": null,
  ...
} 

As for janaipakos/ghibliapi#3, it is Closed and Merged

 // 20171012084422
// https://api.github.com/repos/janaipakos/ghibliapi/pulls/3

{
  "url": "https://api.github.com/repos/janaipakos/ghibliapi/pulls/3",
  ...
  "number": 3,
  "state": "closed",
  ...
  "created_at": "2017-03-22T22:35:15Z",
  "updated_at": "2017-03-23T00:09:33Z",
  "closed_at": "2017-03-23T00:09:04Z",
  "merged_at": "2017-03-23T00:09:04Z",
  ...
}

Show Data in a Card

Thanks for showing interest in this project. I'm happy to see you here.
Our task is to showing parsed each pull request in a card (using HTML & CSS). So show your creativity and get your pull request merged in no time.
Contributing to this project is very easy, please go through README.md
Feel free to give any suggestion. ๐Ÿ˜Š

UI Improvement

This page has no design till now. So grab this opportunity and do any changes that make the UI appealing to the user.
Don't use any other framework except Bootstrap.

Parsing the data from JSON

Git REST API v3 is used to get the user data from Github. After parsing the data from JSON, please append username, last 4 pull requests to the element assigned the id=result.
Any other suggestions are most welcome. ๐Ÿ˜Š

Enhance Card Style (HTML, CSS)

Good for the first timer. You need to style the card (in which the data of pull requests is being fetched) however you want it to be. The only condition is it should look elegant. Want to add new feature/change/improve something else??
Come up with your suggestion and open an issue ๐Ÿ˜Š

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.