Comments (7)
Yes, that is indeed an issue with the template.
I had some other plans so added this temporarily. Adding a horizontal scroll would be good as well so I'll add that soon.
I will also take care to request a code review from now on.
from bookstore-template.
I would like to do this. Please assign it to me. Thank you
from bookstore-template.
Good luck @anupriyalathey!
from bookstore-template.
Hey @anupriyalathey are you still working on this? Feel free to provide any updates about the progress.
from bookstore-template.
Thank you for making the template responsive, it is a great addition!
-
What I noticed:
Not all events and genres were added to the breakpoint between 768px to 1199px. -
Outcome:
This would effect users with devices within this breakpoint, since not all the events and genres would be displayed. -
Note:
Please request a code review when required, before merging withmaster
and closing an issue.
Here are some images for context:
- Developer tools for breakpoint 768px to 1199px
- Events and Genres at 768px (This applies to the breakpoint 768px to 1199px)
A suggestion could be a horizontal scroll on the x-axis to display all events and genres between the breakpoint.
Here is a link to a codepen that demonstrates this.
If you would like, you can re-open this issue, or create a new one.
Overall, great work on making it responsive, Sanket!
from bookstore-template.
We'd love to hear your ideas/plans for the next time :)
Thank you for re-opening this issue.
from bookstore-template.
@fabdul88 I've fixed the issue that you referenced in the above PR. Would highly appreciate your reviews to the changes made.
from bookstore-template.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bookstore-template.