sangramjadhav / simple-java-mail Goto Github PK

One other thing which I spotted which aren't catered for by SimpleJavaMail but 
are by the Javamail API.

Headers
-------
Personally, I hate them, but clients are always asking if you can set the 
"important" flag on emails.  This is normally done by setting custom headers 
such as X-Priority and Importance.  To do this, javamail provides 
message.setHeader(String,String).  Would be good to be able to do this in 
simplejavamail

I'm now using simplejavamail "in anger" (although still in a testing phase) so 
I may well suggest some other enhancements as I find them.

As I said last time, great work...much easier than the javamail api.

Tom

When calling

    new org.codemonkey.simplejavamail.Mailer(mySession).sendMail(myEmail);

the following exception occurrs:

    Exception in thread "main" java.lang.NullPointerException
        at org.codemonkey.simplejavamail.Mailer.logSession(Mailer.java:260)
        at org.codemonkey.simplejavamail.Mailer.sendMail(Mailer.java:238)
        at MyClientCode

This is because Mailer.logSession(Session, TransportStrategy) tries to access 
members of the TransportStrategy, which was never initialized by the 
Mailer(Session) constructor.

This is more a feature enhancement than a bug report.  The library seems 
excellent, but the one thing it doesn't support is the "reply to" option which 
JavaMail does.  Should just be a case of adding

1. a setReplyTo(String replyto) method to Email
2. a getReplyTo() method to Email
3. a check in Mailer to see whether a reply to is set and use it

This can be quite an important flag if using libraries in applications where 
you are sending on behalf of someone else.

Other than that, excellent work.

Need to document developer logging options, system properties, 
logging.properties, etc.

I could find no information on this on your page.  If there, please provide a 
link...

Thanks,
Jeff

There are some email addresses that behave *very* poorly with the validation 
done in EmailValidationUtil.  I think it might be due to the nested quantifiers 
in the complex regexes there.  They literally take hours to finish the 
validation, using 100% CPU.

Is there any way to fix this, and barring that, can an option be added to skip 
validation?

To reproduce:
1. Try to send an email to an address like 
[email protected]
2. Wait for computer to explode

(Using java 1.6.0_31)

Allow use of this class outside package

It would be nice to be able to enable the "mail.debug" property that javamail 
supports, so that a full communication log with the mail server can be logged.

What steps will reproduce the problem?
1. Attach a file with åäö characters in them (like image)
2. Recieve the email and see åäö is now incorrectly encoded.
3.

What is the expected output? What do you see instead?
The file attached with correct name. The file attached with swedish characters 
garbled


What version of the product are you using? On what operating system?
2.1


Please provide any additional information below.
I did a quick google and mail attachmanet names needed to be encoded correctly. 
And I wonder if this is lacking.

It would be nice to add a feature that performs all sorts of validations on the 
email, but stops short from actually delivering the email over the network.  
For unit testing purposes, etc.

What steps will reproduce the problem?
1. Try to send email to å[email protected]

What is the expected output? What do you see instead?
Email should send according to http://tools.ietf.org/html/rfc6531

Instead i get: Get this error Could not send email. Inner error: Invalid TO 
address: org.codemonkey.simplejavamail.Email@60e6e627

What version of the product are you using? On what operating system?
I use 2.1 on windows

Please provide any additional information below.

What steps will reproduce the problem?
1. Just trying to implement the example that you provided in the wiki

What is the expected output?
Nothing just email has to be sent...

What do you see instead?
See here: http://pastebin.com/t58fWEpG

What version of the product are you using? On what operating system?
Latest

Please provide any additional information below.
Trying to send email with gmail. Added your libraries and code compiles OK. I'm 
using Eclipse on Xubuntu 11.10.