Questions and decisions

v1 and v2 maintenance

• Use two git branches?

  • (+) dual changes: allows cherry-picking

• Use two solutions in one git branch?

  • (-) dual changes: copy code or use complex file links and conditional symbols

• decide how:

  • branch release/v1.1 to maintain v1.1
  • branch release/v1.2 to maintain v1.2
  • branch release/v2.2 to maintain v2.0
  • branch dev/vX/FEATURE for development
  • remove branch master
  • change solution name to avoid IDE craziness

Target frameworks for v2

• SrkToolkit.Common should have maximum framework compatibility, because there is not much framework-specific code.
  • net40/net45/net46 (for FX aficionados)
  • net6.0/net7.0 (why? / why not?)
  • netstandard2.0 (for whatever else)
• SrkToolkit.Domain should use the same support as SrkToolkit.Common
• AspMvc4
  • SrkToolkit.Web.AspMvc4 -> drop support in v2 (old stuff -> use v1)
  • SrkToolkit.Domain.AspMvc4 -> drop support in v2 (old stuff -> use v1)
• AspMvc5
  • SrkToolkit.Web.AspMvc5 -> drop support in v2 (old stuff -> use v1)
  • SrkToolkit.Domain.AspMvc5 -> drop support in v2 (old stuff -> use v1)
• AspNetCore2
  • SrkToolkit.Web.AspNetCore2 -> added support in v2
  • SrkToolkit.Domain.AspNetCore2 -> added support in v2

Some WebDependency should be loaded using the new async attribute. The following code should generate a <script async> tag.

return new WebDependency("BigScript")
{
    new WebDependencyFile("/Scripts/BigScript.js", WebDependencyFileType.Javascript)
    {
        Async = true,
    },
};

The Dictionary class throws an exception when you index-access an item that does not exist.

var dictionary = new Dictionary<string, string>();
var value = dictionary["Hello"]; // throws KeyNotFoundException: The given key was not present in the dictionary

We would like a method that would return null instead of throwing an exception.

Invading the System namespaces should not continue. But what namespace should we use?

Use a prefix notation like this?

• System -> SrkToolkit.System
• System.Collections -> SrkToolkit.System.Collections
• ...

(-) This may lead to a lot of new using statements.
(+) Fine-grained choice of extensions to use

Or use a single namespace? SrkToolkit.Extensions?

(-) This may lead to a binary choice of using all referenced toolkits or none.
(+) Binary-grained choice of extensions to use

Or put extensions in each nuget's namespace? SrkToolkit.Common, SrkToolkit.Web...

(+) Coarse-grained choice of extensions to use
(+) This may lead to an acceptable quantity of new using statements.

Current extension method:

bool ContainsAny(IEnumerable<string> values, StringComparison comparisonType);

Desired overloads:

bool ContainsAny(StringComparison comparisonType, params string[] values);
bool ContainsAny(StringComparison comparisonType, params char[] values);

These things require specific change, decide what to do with them

• SrkToolkit.Services
  • keep AppEventBus, ApplicationServices, FileTraceListener, TraceEx
• SrkToolkit.Mvvm
  • drop support
• SrkToolkit.Xaml
  • drop support
• SrkToolkit.Common
  • TODO: list things here
  • Collections.DictionaryWrapper<TKey, TValue>: preserved
  • DataAnnotations.CultureInfoAttribute: upgrade and preserve
  • DataAnnotations.DateRangeAttribute: upgrade and preserve
  • DataAnnotations.EmailAddressExAttribute: upgrade and preserve
  • DataAnnotations.PhoneNumberAttribute: upgrade and preserve
  • DataAnnotations.TimezoneAttribute: upgrade and preserve
  • DataAnnotations.TwitterUsernameAttribute: upgrade and preserve
  • CultureInfoHelper: upgrade and preserve
  • Internals.Nothing: preserved
  • IO.RecursiveDelete:
    • preserved
    • requires testing
    • needs an async method
  • System.DateTimePrecision: preserved, namespace must change (#21)
  • System.SrkArrayExtensions: preserved, namespace must change (#21)
  • System.SrkDateTimeExtensions: preserved, namespace must change (#21)
  • System.SrkExceptionExtensions: preserved, namespace must change (#21)
  • System.SrkStringExtensions: preserved, namespace must change (#21)
  • System.SrkTimeZoneInfoExtensions: preserved, namespace must change (#21)
  • System.SrkStringTransformer: preserved, namespace must change (#21)
  • System.Collections.SrkIDictionaryExtensions: preserved, namespace must change (#21)
  • System.Collections.Generic.SrkIDictionaryExtensions: preserved, namespace must change (#21)
  • System.Collections.Generic.SrkIListExtensions: preserved, namespace must change (#21)
  • System.Collections.ObjectModel.SrkObservableCollectionExtensions: preserved, namespace must change (#21)
  • System.Collections.Specialized.SrkNameValueCollectionExtensions: preserved, namespace must change (#21)
  • System.Diagnostics.StopwatchExtensions: preserved, namespace must change (#21)
  • Testing.Assert: preserved
  • Threading.Tasks.TaskEx: preserved
  • Validation.EmailAddress: preserved
  • Validation.Validate: preserved
  • CompositeDisposable: preserved
  • DisposableOnce: preserved
  • EnumTools: preserved
  • RetryLogic: preserved, now obsolete
  • StringComparerEx: preserved
  • StringReplacer: preserved
• SrkToolkit.Domain
  • preserve everything
• SrkToolkit.Web.AspNetCore2
  • TODO: list things here
  • Fakes/BasicHttpContext: does not compile, seems useless with AspNetCore2?
  • Fakes/BasicHttpSessionState: does not compile, seems useless with AspNetCore2?
  • Filters/AuthorizeAttribute: does not compile, seems useless with AspNetCore2?
  • HttpErrors/*: does not compile, evaluate if useful with AspNetCore2?
  • Models/HttpErrorModel: looks ok, evaluate if useful with AspNetCore2?
  • Models/TempMessage: ok
  • Mvc/DecimalModelBinder: does not compile, migrate!
  • Mvc/IntegerModelBinder: does not compile, migrate!
  • Open/Open*: looks ok,
  • Open/PageInfo*: looks ok,
  • Services/HttpBaseSessionServiceSource, BaseSessionService: evaluate if useful with AspNetCore2?
  • Services/ResultServiceBase, ResultService: evaluate if useful with AspNetCore2?
  • SrkControllerExtensions: does not compile, migrate!
  • SrkMvcCollectionExtensions: looks ok, change namespace
  • SrkTagBuilderExtensions: does not compile, migrate! change namespace
  • SrkUrlHelperExtensions: looks ok, change namespace
  • SrkViewExtensions: does not compile, migrate! change namespace
  • JsonNetResult: evaluate if useful with AspNetCore2?
  • SrkHtmlExtensions: does not compile, migrate!
  • SrkHttpApplication: seems useless with AspNetCore2?
  • SrkHttpContextExtensions: does not compile, migrate!
  • SrkHttpRequestExtensions: does not compile, migrate!
  • SrkTempDataDictionaryExtensions: compiles, does it work?
  • WebDependency, WebDependencyFile, WebDependencies, WebDependenciesExtensions: does not compile, evaluate if useful with AspNetCore2
  • review namespaces
• SrkToolkit.Domain.AspNetCore2
  • TODO: list things here
  • SrkDomainControllerExtensions: does not compile, migrate!

The projects use <ProjectReference> elements. This causes nuget packages to reference strict version conditions.

Try to use this solution to allow loose references between packages.

What we see in the VS Test Explorer:

Test Outcome:   Failed
Test Duration:  0:00:00.1276359

Result Message: 
Test method threw exception: 
System.ArgumentException: Searched string was not found
Result StackTrace:  
at SrkToolkit.Testing.Assert.Contains(String search, String value) in NET4.SrkToolkit.Common\Testing\Assert.cs:line 159

I would be nice to also see the string that was searched.

Current behavior

new WebDependencyFile("/Scripts/common.js", WebDependencyFileType.Javascript) renders as src="/Scripts/common.js"; which is OK but does not allow to put the app in a site subfolder.

new WebDependencyFile("~/Scripts/common.js", WebDependencyFileType.Javascript) renders as src="~/Scripts/common.js"; which is wrong.

Desired behavior

new WebDependencyFile("/Scripts/common.js", WebDependencyFileType.Javascript) should not change.

new WebDependencyFile("~/Scripts/common.js", WebDependencyFileType.Javascript) should render as src="/subfolder/Scripts/common.js"; where /subfolder if computed using the base app url.

EmailAddressExAttribute is missing from the netstandard2.0 build

This configuration (firefly) fails to build the solution

"/home/sandrock/dev/github/sandrock/srktoolkit-v2/Sources/SrkToolkit.Common/SrkToolkit.Common.csproj" (build target) (2) ->
(GetReferenceAssemblyPaths target) -> 
/usr/lib/mono/msbuild/Current/bin/Microsoft.Common.CurrentVersion.targets(1232,5): error MSB3971: The reference assemblies for ".NETFramework,Version=v7.0" were not found. You might be using an older .NET SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.

"/home/sandrock/dev/github/sandrock/srktoolkit-v2/Sources/SrkToolkit.Domain/SrkToolkit.Domain.csproj" (build target) (1:2) ->
/usr/lib/mono/msbuild/Current/bin/Microsoft.Common.CurrentVersion.targets(1232,5): error MSB3971: The reference assemblies for ".NETFramework,Version=v7.0" were not found. You might be using an older .NET SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.

"/home/sandrock/dev/github/sandrock/srktoolkit-v2/Sources/SrkToolkit.Common/SrkToolkit.Common.csproj" (build target) (2:2) ->
(ResolvePackageAssets target) -> 
/usr/lib/mono/msbuild/Current/bin/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(241,5): error NETSDK1005: Assets file '/home/sandrock/dev/github/sandrock/srktoolkit-v2/Sources/SrkToolkit.Common/obj/project.assets.json' doesn't have a target for '.NETFramework,Version=v4.7.2'. Ensure that restore has run and that you have included 'net472' in the TargetFrameworks for your project.

dotnet sdk check
.NET SDKs:
Version      Status
----------------------------------------
2.2.207      .NET 2.2 is out of support.
3.1.120      .NET 3.1 is out of support.
6.0.113      Patch 6.0.115 is available.
7.0.102      Patch 7.0.104 is available.

Try out the newest .NET SDK features with .NET 8.0.100-preview.2.23157.25.

.NET Runtimes:
Name                          Version      Status
----------------------------------------------------------------------
Microsoft.NETCore.App         2.2.8        .NET 2.2 is out of support.
Microsoft.NETCore.App         3.1.20       .NET 3.1 is out of support.
Microsoft.NETCore.App         6.0.13       Patch 6.0.15 is available.
Microsoft.AspNetCore.App      7.0.2        Patch 7.0.4 is available.
Microsoft.NETCore.App         7.0.2        Patch 7.0.4 is available.

Third step towards netstandard

While most domain data is implemented in child classes (out out SrkToolkit), the result error messages are declared by SrkToolkit. These do not allow localization. Developers must implement on their side lang negociation in order to obtain localized error messages.

Can SrkToolkit.Domain be enhanced?

• by defining request properties to set the desired lang, time zone, date format and more?
• or by allowing multi lang error messages?
• or any other way?

• 2.0 preview1
  • contains easily migrated things
  • https://www.nuget.org/packages/SrkToolkit.Common/2.0.144-preview1
  • https://www.nuget.org/packages/SrkToolkit.Domain/2.0.145-preview1
  • https://www.nuget.org/packages/SrkToolkit.Web.AspNetCore2/2.0.144-preview1
  • https://www.nuget.org/packages/SrkToolkit.Domain.AspNetCore2/2.0.144-preview1
• fix missing package icon
• fix missing SrkToolkit.DataAnnotations
• 2.0 preview1 final (WIP)
• fix missing package README
• loose reference version between nugets ref
• 2.0 preview2
• 2.0.0-rc1
  • contains most things
• 2.0.0
  • stable-enough release

The following code seem to work in state.

Validation attributes return a ValidationResult object in case of error. The result should contain a message and a member name.

The EmailAddressExAttribute does not specify the member names when an error is found.

First step towards netstandard

Second step towards netstandard