Loading time about universal-lpc-spritesheet-character-generator HOT 3 CLOSED

Yeah I know, thought about it as well. I think the three ideas you suggest might help to some extent, but in the end the current solution is just not that scalable (generating the html on load).

Hence, I was actually thinking to generate the HTML locally before pushing as pre-push hook.
Then once generated the script will also create hash of the file, which can be used to assess the integrity later.
This is needed as we dont want people to manually change the generated index.html and then push that.

This will also require that I add a job on the CI that will actually also create the index.html, hash it and compare that hash with the hash of the current PR. If the don't match, the pipeline fails and one cant proceed with his/ her PR.

What would you think about that?

from universal-lpc-spritesheet-character-generator.

@bluecarrot16 I pushed a new change. In this change, and now the index.html is pre-generated.

There is JS script here (you can just run it with node) that uses the source index and generates the index.html from there.

I didnt polish it yet nor did I update the readme, I first wanted to confirm first that the page is loading faster now. Personally I think it is, what do you say?

from universal-lpc-spritesheet-character-generator.

Fixed

from universal-lpc-spritesheet-character-generator.