CORS issues about universal-lpc-spritesheet-character-generator HOT 6 CLOSED

Yes indeed, the CORS issue I think affects all local runs. Not sure how to resolve it either, I usually do the same as you by adding the flag.
Alternatively, you can disable loading of the credits.csv in the sources, as the XMLHttpRequest that is done there is what is actually causing the issue AFAIK.

I can add it to the readme, or if you like, you could submit a PR as well :)

from universal-lpc-spritesheet-character-generator.

Okay I will open a PR. I want to first see if its fixable otherwise I will open a PR to update the README.

from universal-lpc-spritesheet-character-generator.

Unfortunately the only way to fix the issue would be to use a server to serve the files (https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSRequestNotHttp). By the way, did anyone ever consider rewriting the frontend in a modern framework?

from universal-lpc-spritesheet-character-generator.

Its certainly possible, but this is more of a passion project that's done casually. As such, Sanderfrenken and others don't like making big changes. The biggest change recently was adding all the new animations which was done by me specifically.

from universal-lpc-spritesheet-character-generator.

Have to say that I'm not against big changes. But myself I am very busy with developing a new game, and I use this generator as a tool for generating characters. In game for the players, I developed a new character generator but that is written fully in Swift.

As of this project, I know the code is quite old and not ideally setup. On the other side, it gets the job done, and aside from some quirks here and there (like the CORS issue when running locally) I don't see big reasons to rewrite to some new framework like React or Vue or whatever.

There have been projects started in the past to make a rewrite happen like the most recent one here:

https://github.com/BenCreating/LPC-Spritesheet-Generator

But its quite a job to rebuild all functionality and drop in all assets as supported by the version you are looking at in this repo.

from universal-lpc-spritesheet-character-generator.

Understandable. Thanks for the answers. I will close this issue now.

from universal-lpc-spritesheet-character-generator.