Code Monkey home page Code Monkey logo

Comments (6)

SamuelScheit avatar SamuelScheit commented on August 17, 2024 4

As a workaround until I find a solution you can prevent node from crashing on errors via

process.on('uncaughtException', function (err) {
  console.error(err);
});

The error is probably caused because the stream is not properly closed, I'll investigate

from puppeteer-stream.

saif-o99 avatar saif-o99 commented on August 17, 2024 1

@SamuelScheit Hey, any news on this ?

from puppeteer-stream.

dcprime avatar dcprime commented on August 17, 2024

I'm also seeing this same issue. Can't find a good way to close the process after the stream has finished writing.

from puppeteer-stream.

dhavalCode avatar dhavalCode commented on August 17, 2024

Facing same issue. @SamuelScheit Please have a look on it.

from puppeteer-stream.

unravelers-tech avatar unravelers-tech commented on August 17, 2024

The workaround that worked for me.

The most critical line is:

  • await page.evaluate((index) => window.STOP_RECORDING?.(index), i); since the extension page maintains a web socket connection and recorders that try to access a closed browser.
await stream.destroy();

await new Promise((resolve) => {
  file.close(async () => {
    const pages = await browser.pages();

    for (let i = 0; i < pages.length; i++) {
      const page = pages[i];

      // @ts-expect-error - get STOP_RECORDING from extension page.
      await page.evaluate((index) => window.STOP_RECORDING?.(index), i);

      await page.close();
    }

    await browser.close();

    wss.close(() => {
      resolve(undefined);
    });
  });
});

cc. @SamuelScheit @saif-o99 @dcprime @dhavalCode @xuhpppp

from puppeteer-stream.

farzadso avatar farzadso commented on August 17, 2024

@SamuelScheit Thanks for your awesome library. Did you ever find a fix for this?

from puppeteer-stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.