Comments (6)
As a workaround until I find a solution you can prevent node from crashing on errors via
process.on('uncaughtException', function (err) {
console.error(err);
});
The error is probably caused because the stream is not properly closed, I'll investigate
from puppeteer-stream.
@SamuelScheit Hey, any news on this ?
from puppeteer-stream.
I'm also seeing this same issue. Can't find a good way to close the process after the stream has finished writing.
from puppeteer-stream.
Facing same issue. @SamuelScheit Please have a look on it.
from puppeteer-stream.
The workaround that worked for me.
The most critical line is:
await page.evaluate((index) => window.STOP_RECORDING?.(index), i);
since the extension page maintains a web socket connection and recorders that try to access a closed browser.
await stream.destroy();
await new Promise((resolve) => {
file.close(async () => {
const pages = await browser.pages();
for (let i = 0; i < pages.length; i++) {
const page = pages[i];
// @ts-expect-error - get STOP_RECORDING from extension page.
await page.evaluate((index) => window.STOP_RECORDING?.(index), i);
await page.close();
}
await browser.close();
wss.close(() => {
resolve(undefined);
});
});
});
cc. @SamuelScheit @saif-o99 @dcprime @dhavalCode @xuhpppp
from puppeteer-stream.
@SamuelScheit Thanks for your awesome library. Did you ever find a fix for this?
from puppeteer-stream.
Related Issues (20)
- Chrome 115 issues? HOT 2
- What parameters should I configure to improve my video?
- Shutdown is taking more than 5 seconds HOT 7
- [QUESTION] How can I record only part of a page? HOT 1
- Allow configuring websocket port
- Recorder giving empty file
- Recorder giving an empty video file
- A solution for non-seekable video files. HOT 1
- Electron build fails to access stream extension workaround
- Want to run two recordings simultaneously HOT 4
- Advice for taking the last 10s of audio without FFMPEG or re-encoding HOT 1
- Option to specify the websocket port
- Using FFMPEG give an error HOT 1
- Wrong resolution in FFMPEG from the Pipe HOT 1
- Process hangs after recording finished
- Are transparent videos possible?
- videoConstraints Not works HOT 3
- [feature request] streaming part of the webpage
- Use it with an existing HTTP server.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppeteer-stream.