Shutdown is taking more than 5 seconds about puppeteer-stream HOT 7 CLOSED

this is required, because some packets might be delayed and take some time to get delivered, the timeout ensures that these packets arrive and the full length of the video is recorded.

from puppeteer-stream.

at least make the timeout configurable

from puppeteer-stream.

and you can also check if socket is already closed before creating timeout

from puppeteer-stream.

Done in [email protected]:

const stream = getStream(page, { 
  streamConfig: {
    closeTimeout: 5000
  }
})

from puppeteer-stream.

this is great! thank you so much! Especially for the fastest response ever!
The requirement of my app is to shutdown as fast as possible when everything is processed (ffmpeg was already closed at that point and video produced)

from puppeteer-stream.

btw, since we're talking about script closing, I sometimes get (Runtime.callFunctionOn): Target closed when extension.evaluate((index) => STOP_RECORDING(index), index) is run.
I belive you can a catch there.

from puppeteer-stream.

can you please catch errors in extension.evaluate((index) => STOP_RECORDING(index), index)
I get this most of the time

uncaughtException: Protocol error (Runtime.callFunctionOn): Target closed
TargetCloseError: Protocol error (Runtime.callFunctionOn): Target closed

from puppeteer-stream.