samuelechu / youtube-playlist-downloader-for-ios Goto Github PK

I want to implement it, but I'm busy now, but I will implement it.

If you accidentally lock the screen while video playback, black screen shown instead of the video when you unlock it. Though audio still work, playback controls are still work, but video is blank.

When trying to get the next song from the lock screen it stop and can't continue unless opening the app again .

And thank you for this awesome working project

Because I now have two identical ones (hopefully one of them is 720p)

It looks like the function call to isVideoStored() in
https://github.com/samuelechu/YoutubePlaylist-Downloader/blob/master/Music%20Player/DownloadManager.swift#L60

also deletes the video in question if the quality is not the same as the desired quality set.
If a 360p video is set to be downloaded and a 720p video of it exists, the 720p video is deleted before the download even starts. This is potentially bad if the user downloads some large playlist frequently and forgets to change the quality in settings.

Deleting a video in a function named in a way that only a check is expected is bad design

This might be unintended behaviour that:

1. downloaded videos participate in iTunes Backup
2. downloaded videos may participate in iCloud Backup (fortunately, I had it disabled so it did not caused any problems for me; I'm also not going to enable it, so can't check if it does going to eat much traffic)

This might be a good idea to mark downloads for no backup 😉

Doesn't let me pod install:

[!] Unable to satisfy the following requirements:

• XCDYouTubeKit (~> 2.5.4) required by Podfile
• XCDYouTubeKit (= 2.5.4) required by Podfile.lock

None of your spec sources contain a spec satisfying the dependencies: XCDYouTubeKit (~> 2.5.4), XCDYouTubeKit (= 2.5.4).

You have either:

• out-of-date source repos which you can update with pod repo update.
• mistyped the name or version.
• not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

Hi,

First, your project is really great, I was looking for an application like that.

Secondly, as you can see in the attached image, I can't access to the download or search button in the Youtube Search View. It seems that the following code in SearchWebViewController.swift
webView.frame = CGRect(height: view.frame.height - tabBarHeight) does not work on my iPhone 5S. It's weird because it's working on a iPhone 5S simulator... An intuition?

Thirdly, I please need help. I would like to access the "addPlaylist(name: String)" function (in PlaylistsTableViewController.swift) in another swift class that I created in Main/Misc folder. I want to create a playlist programmatically. I tried to implement something like the "tableDelegate" in DataDownloader.swift but without success. I'm missing something. Can you please give me a trail?

Thank you very much.

Thomas

oh no...............

clang: error: linker command failed with exit code 1 (use -v to see invocation)