samthegamer39 / minecraftrailroadblocks Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 1.0 198 KB

A mod that adds various railroad-themed blocks to Minecraft.

License: MIT License

Java 100.00%

fabric fabricmc fabricmc-mod forge forge-mod minecraft minecraft-fabric minecraft-forge minecraft-mod mod neoforge

minecraftrailroadblocks's Issues

Blocks can't rotate.

The blocks do not support rotating, but they should.

Registry is Already Frozen Error.

Describe the bug
After updating the mod to 1.18.x, the mod will not run properly. It will create the following error: `java.lang.IllegalStateException: Registry is already frozen'. This prevents both the mod and Minecraft from running normally. It appears that during the block registration process, the mod gets stuck or something, preventing the mod from registering the blocks to the registry. This times out and the registry is then frozen. Since blocks cannot be added after the registry freezes, the mod cannot load properly and it creates an exception. It appears the error comes from line 28 of the SignBlock.java class (although testing shows it also occurs on line 26 in the PoleBlock.java class).

27    public SignBlock(Properties properties) {
28        super(properties); //Why does this break EVERYTHING?
29        this.registerDefaultState(this.defaultBlockState()
30                .setValue(HORIZONTAL_FACING, Direction.NORTH)
31                .setValue(WATERLOGGED, false));
32    }

To Reproduce
Steps to reproduce the behavior:

Load the dev branch (1.18.x) into an IDE set up for Minecraft 1.18.2 with Forge. (Alternatively, create a .jar file using an IDE and load that into an instance of Minecraft 1.18.2 with Forge.
Start Minecraft using the runClient gradle task (or boot up Minecraft normally).
Wait for Minecraft to load.
Minecraft will fail to load properly and will display the following error and will refuse to continue.

Railroad Blocks (railroadblocksaddon) has failed to load correctly
java.lang.reflect.InvocationTargetException: null

The IDE will show the following error `java.lang.IllegalStateException: Registry is already frozen'

Expected behavior
The mod should load all blocks to the registry prior to the registry freezing and should load with Minecraft without crashing.

Additional Information:

Minecraft Version: 1.18.2
Mod Version: 0.3.1
Forge Version: (TBD)

Log File

---- Minecraft Crash Report ----
// You're mean.

Time: 8/10/22, 5:54 PM
Description: Mod loading error has occurred

java.lang.Exception: Mod Loading has failed
	at net.minecraftforge.logging.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:55) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading}
	at net.minecraftforge.client.loading.ClientModLoader.completeModLoading(ClientModLoader.java:169) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.lambda$new$1(Minecraft.java:555) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.Util.ifElse(Util.java:397) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.client.Minecraft.lambda$new$2(Minecraft.java:549) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screens.LoadingOverlay.render(LoadingOverlay.java:135) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.renderer.GameRenderer.render(GameRenderer.java:877) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1044) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:663) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:205) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
	at net.minecraftforge.fml.loading.targets.ForgeClientUserdevLaunchHandler.lambda$launchService$0(ForgeClientUserdevLaunchHandler.java:24) ~[fmlloader-1.18.2-40.1.0.jar%230!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:149) [bootstraplauncher-1.0.0.jar:?] {}


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at net.minecraftforge.registries.NamespacedHolderHelper.createIntrusiveHolder(NamespacedHolderHelper.java:177) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading}
-- MOD railroadblocksaddon --
Details:
	Caused by 0: java.lang.reflect.InvocationTargetException
		at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
		at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
		at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
		at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {}
		at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {}
		at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:67) ~[javafmllanguage-1.18.2-40.1.0.jar%2377!/:?] {}
		at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:106) ~[fmlcore-1.18.2-40.1.0.jar%2379!/:?] {}
		at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
		at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
		at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}
		at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}

	Caused by 1: java.lang.ExceptionInInitializerError
		at io.github.samthegamer39.railroadblocksaddon.RailroadBlocksAddon.<init>(RailroadBlocksAddon.java:31) ~[%2380!/:?] {re:classloading}
		at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
		at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
		at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
		at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {}
		at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {}
		at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:67) ~[javafmllanguage-1.18.2-40.1.0.jar%2377!/:?] {}
		at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:106) ~[fmlcore-1.18.2-40.1.0.jar%2379!/:?] {}
		at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
		at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
		at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}
		at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}
		at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}

	Mod File: main
	Failure message: Railroad Blocks (railroadblocksaddon) has failed to load correctly
		java.lang.reflect.InvocationTargetException: null
	Mod Version: 0.0NONE
	Mod Issue URL: https://github.com/SamTheGamer39/MinecraftRailroadBlocks/issues
	Exception message: java.lang.IllegalStateException: Registry is already frozen
Stacktrace:
	at net.minecraftforge.registries.NamespacedHolderHelper.createIntrusiveHolder(NamespacedHolderHelper.java:177) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading}
	at net.minecraftforge.registries.NamespacedDefaultedWrapper.createIntrusiveHolder(NamespacedDefaultedWrapper.java:205) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading}
	at net.minecraftforge.registries.NamespacedDefaultedWrapper.createIntrusiveHolder(NamespacedDefaultedWrapper.java:33) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2375%2381!/:?] {re:classloading}
	at net.minecraft.world.level.block.Block.<init>(Block.java:67) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.block.HorizontalDirectionalBlock.<init>(HorizontalDirectionalBlock.java:12) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at io.github.samthegamer39.railroadblocksaddon.common.blocks.SignBlock.<init>(SignBlock.java:28) ~[%2380!/:?] {re:classloading}
	at io.github.samthegamer39.railroadblocksaddon.init.BlockInit.<clinit>(BlockInit.java:25) ~[%2380!/:?] {re:classloading}
	at io.github.samthegamer39.railroadblocksaddon.RailroadBlocksAddon.<init>(RailroadBlocksAddon.java:31) ~[%2380!/:?] {re:classloading}
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {}
	at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {}
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:67) ~[javafmllanguage-1.18.2-40.1.0.jar%2377!/:?] {}
	at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:106) ~[fmlcore-1.18.2-40.1.0.jar%2379!/:?] {}
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}

Mod doesn't work on NeoForge for Minecraft 1.20.5

Describe the bug
v0.4.0 doesn't work on NeoForge for the new Minecraft version 1.20.5

To Reproduce
Steps to reproduce the behavior:

Download v0.4.0 for NeoForge
Download Minecraft 1.20.5 with the newest version of NeoForge (20.5.0-beta).
Place Railroad Blocks v0.4.0 into the mods folder
Attempt to run Minecraft.
Minecraft will run, but the mod will not appear in game.

Expected behavior
The mod should appear in game and its blocks and items added to the game.

Additional Information (please complete the following information):

Minecraft Version: 1.20.5
Mod Version: 0.4.0
Mod Loader: NeoForge
Mod Loader Version: 20.5.0-beta

Additional context
NeoForge changed how mods should be created for its 1.20.5 release, so an update to this mod will be necessary.

Support for NeoForge on Minecraft Versions 1.20.2+

Describe the feature you'd like
This mod should be available for NeoForge on Minecraft versions 1.20.1+

Additional context
NeoForge is currently supported for Minecraft 1.20.1, since no code changes were required to support that version. However, NeoForge has changed and must be specifically supported for future versions.

Train Signals

Difficulty: Medium

Notes: While this block is of importance, and I would love to add it. It is very difficult to make (especially if I attempt to avoid using redstone). This will be staying in consideration for now.

Minimum features are features required before I will release this to the public. Recommended features are goals/ideas I would love to include for this item.

Minimum:

A block capable of changing between a red/green light based on redstone or other input.
Signal light visibly glows (has constant brightness despite external conditions).
Stand/gantry for signal.

Difficult:

Capable of compliance with NORAC Signal Rules (for example, being able to displaying a flashing state for each light as well as being able to display red/yellow/green states).
Find alternative to redstone to provide more realistic feel.

Collision boxes are the wrong size.

Currently, the collision boxes for the objects are the size of a full block, but they should be close to the size of the actual object.

Minecraft Crashes when Viewing Mod List with NeoForge

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Start Minecraft 1.20.2 with NeoForge
Wait for Minecraft to load
Click "Mods" in the main menu
Find and click on "Railroad Blocks" in the list
Minecraft crashes unexpectedly

Expected behavior
Instead of crashing, the details of this mod should appear instead.

Additional Information (please complete the following information):

Minecraft Version: 1.20.1
Mod Version: 0.4.0
Mod Loader: NeoForge
Mod Loader Version: 20.2.88

Additional context
This issue is not present when running the mod on 1.20.4 with NeoForge, which suggests the issue may be with the mod loader and not with the mod itself, however, this is unclear.

Collision Box is Misaligned

Describe the bug
The collision box for all sign blocks are slightly misaligned in three out of four directions. The issue is minor, but could cause minor collisions.

Fixing this may require optimizing the code for rotatable blocks, which has not worked so far.

To Reproduce
Steps to reproduce the behavior:

Select any sign block
Place block
Hover mouse over collision box to view misalignment.

Expected behavior
The collision box should align with the shape of the sign blocks.

Additional Information (please complete the following information):

Minecraft Version: 1.16.x
Mod Version: 0.1.2, 0.2.0
Forge Version: N/A

Shadows are the wrong size/should not be present.

Minecraft renders the blocks as if they are not transparent, even though they mostly are.

Updating 1.18.x and 1.16.x Versions of Railroad Blocks

Describe the feature you'd like
1.18.x and 1.16.x currently only have outdated versions of this mod available. v0.4.0 (or a newer version of this mod) should be available for these versions.

Some new ports

Describe the feature you'd like
I would like that the versions for minecraft 1.19.2 forge and 1.18.2 to be added, because i want to use it with the Create mod to decorate my railway built with the Create mod.

Is your feature request related to a problem? Please describe if applicable.
I'm always frustrated that there is only version of this mod for 1.19.2 fabric but not forge

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Blocks don't exist.

Forge version does not work on 1.19.3

Describe the bug
When launching Minecraft 1.19.3 with the Forge version of Minecraft Railroad Blocks installed, Minecraft will refuse to launch.

To Reproduce
Steps to reproduce the behavior:

Go to Minecraft
Ensure you are on version 1.19.3 and using the Forge version of the mod.
Launch Minecraft
See error

Expected behavior
Minecraft should boot normally and the mod should load.

Additional Information:

Minecraft Version: 1.19.3
Mod Version: 0.3.3
Mod Loader: Forge
Forge Version: 44.1.0

Screenshots

Additional context
This has been determined to be caused by a change in Minecraft's code. Specifically, the location of the register in Minecraft has changed, and the mod must be updated to correct the issue.

Blocks are not visible.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

samthegamer39 / minecraftrailroadblocks Goto Github PK

minecraftrailroadblocks's Issues

Minimum:

Recommended:

Difficult:

Recommend Projects

Recommend Topics

Recommend Org