samt / http-post Goto Github PK

Hello, the NPM README/docs has an invalid example code

https://www.npmjs.com/package/http-post#examples

http.post('http://localhost/postscript.php', { name: 'Sam', email: '[email protected]' }, function(res){
	response.setEncoding('utf8');
	res.on('data', function(chunk) {
		console.log(chunk);
	});
});

response.setEncoding('utf8'); should be res.setEncoding('utf8');

I need to get some tests up for this... eventually it will happen

It would be nice to be able to send the Content-Type header with each file, even though I've yet to test this with a server that rejects the request or mutilates the file due to its absence.

I want to create a web crawler with this module, it seams that it does not support cookies.?

The current implementation loads the entire file into memory and tosses it to req.write() at once. This will fail for larger files. Some sort of buffered read to req.write() needs to be implemented.

I tryed

var req = http.post(options, authParams, {param: 'file', path: '/tmp/test.zip'}, reqCallback);

On server, I can see that the request itself is working, but the file is not getting there.

I used the "request" module and it worked, it sent the file, but I really would prefer to use the "http-post" module, since "request" adds almost 3MB of dependencies to my project.

Am I doing something wrong?

Pls provide an example to post a file as welll as data using the http-post module.

Thanks,

This doesn't seem to support https, it would be great if you wanted to add that! I may do a PR in the coming weeks if I have the time.