samply / sample-locator Goto Github PK

See below

Like in blaze-quality-reporting-ui we need a build container which runs ng build --prod so Docker Hub can build our images automatically.

Without the default values, env.js is invalid and so nothing is shown in the browser if the container is started without any env vars.

Damit man mal sieht, wie ich mir das vorstelle:

At startup the field Diagnosis ICD-10 is preselected. If you enter a value and click on SEND, it only adds an empty value field without sending a query. A second SEND is necessary which is a little bit confusing.
This does not apply to every field type, but for String/Integer fields.

Possible solution:
When the user starts typing an Integer/String, a new empty field should appear, not only after pressing ENTER or clicking elsewhere, it should be like the behavior of selecting an Enumeration or using the up/down arrows on Integer fields.

In some files like Shell scripts, it's important to ensure linux line endings. Under Windows Git normally keeps Windows line endings in the working directory and can be configured to commit files with linux file endings. However Windows developers using Docker build will insert files with Windows file endings in the container image.

To ensure linux line endings even in the Windows working directory, Git can be configures through the .gitattributes file. Documentation can be found here and here.

It should be possible and obligatory on the SL UI (detailed result page before starting negotiation) to indicate whether the requesting party is searching in an academic context or whether the request comes from industry. The Negotiator is equipped to handle this information (speak to Robert Rheis or to Petr Holub).

The full result table is not sortable at the moment. It would be user-friendly if the results could be sorted by clicking on headings (small arrows up and down for ASC/DESC, see https://support.rstudio.com/hc/en-us/article_attachments/201725247/viewer.png)

The nToken is not cleared and renewed properly after a successful transfer to Negotiator. This leads to wrong loading of requests.

Bitte Banner "Sample Locator +++ Work in progress +++ Please report any feedback and bugs to [email protected]" von UI entfernen.

Design must be discussed with Verena Huth

We need to get rid of the start.sh still running in the container. A simple exec in front of nginx -g 'daemon off;' will do that.

After a query is sent and the user logged in, the full result appears.
When the user returns to the page after some time, he can see the same content and is able to EDIT the query, after SEND, the result page remains empty because the user is logged out without knowing it and the backend seems not to accept an invalid token.

Possible solution 1: Keep the user logged in (refresh token silently)

Possible solution 2: SEND could check for valid token and present simple result instead