sam-martin / ephemera Goto Github PK

PowerShell only executes on Windows, but there's nothing Windows specific about Epherma's use case.
As such, there should be an installer script that can be run on Linux systems, probably Python.

Hello

If I try to deploy this, the resulting update stack has the bucket specified twice, resulting in the update failing and rolling back

ephemera-dev already exists in stack arn:aws:cloudformation:ap-southeast-2:1234567890:stack/serverless-ephemera-local-dev/afe64d03-eb45-4f1c-816d-133db9d5d4b8

  "S3Bucketephemeradev": {
     "Type": "AWS::S3::Bucket",
     "Properties": {
       "BucketName": "ephemera-dev",
       "NotificationConfiguration": {
         "LambdaConfigurations": [
           {
             "Event": "s3:ObjectRemoved:*",
             "Function": {
               "Fn::GetAtt": [
                 "EphemeraPopulateStaticSiteConfigLambdaFunction",
                 "Arn"
               ]
             }
           },
           {
             "Event": "s3:ObjectCreated:*",
             "Function": {
               "Fn::GetAtt": [
                 "EphemeraPopulateStaticSiteConfigLambdaFunction",
                 "Arn"
               ]
             },
             "Filter": {
               "S3Key": {
                 "Rules": [
                   {
                     "Name": "prefix",
                     "Value": "index.html"
                   }
                 ]
               }
             }
           }
         ]
       }
     },
     "DependsOn": [
       "EphemeraPopulateStaticSiteConfigLambdaPermissionephemeradevS3",
       "EphemeraPopulateStaticSiteConfigLambdaPermissionephemeradevS3"
     ]
   }

    "S3BucketPublicBucket": {
      "Type": "AWS::S3::Bucket",
      "Properties": {
        "WebsiteConfiguration": {
          "IndexDocument": "index.html",
          "ErrorDocument": "error.html"
        },
        "PublicAccessBlockConfiguration": {
          "RestrictPublicBuckets": true
        },
        "BucketName": "ephemera-dev"
      }
    },

I don't understand why as the serverless.yml only defines a single bucket.

When I try to deploy, I get the following error:

An error occurred: EphemeraPopulateStaticSiteConfigLambdaFunction - The runtime parameter of nodejs4.3 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions. (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: f5c800b6-2a31-11e9-9b39-db0fcdad817a).

Pull request here: #16

Serverless Error ----------------------------------------

PublicBucket - Bucket name must conform to pattern (?!^(\d{1,3}.){3}\d{1,3}$)(^(([a-z0-9]|[a-z0-9][a-z0-9-][a-z0-9]).)([a-z0-9]|[a-z0-9][a-z0-9-]*[a-z0-9])$). Please check provider.
s3.PublicBucket and/or s3 events of function "EphemeraPopulateStaticSiteConfig".

Get Support --------------------------------------------
Docs: docs.serverless.com
Bugs: github.com/serverless/serverless/issues
Issues: forum.serverless.com

Hi Sam,

Does this have an expiration after like 24 hours? Or is it available forever unless the link is not clicked?

Regards
Joe

Hi,

I am using Ephemera and it seems to be there is bug where passwords contains < angle bracket is not interpreted properly. it truncates the password contents after the < bracket. Please suggest.

Rgds,
Maya

Having plain text secrets in the (admittedly private) S3 bucket is a missed opportunity.
I should improve the addSecret lambda function to encrypt the text in the file with the KMS key used to decrypt the s3Signer AWS Secret Key.

Probably an escaping issue when added to the html of the page by the client side JavScript.