The example pillar in the readme differs from the pillar.example which caused a bit of confusion as to why it wasn't working. Recommend just removing that example so it just gets maintained in one spot :)

The current defaults.yml (below) sets default params fs-file-max:100000 and vm.swappiness:20 . Are these truly good sensible defaults that we should always be applying? I am the opposite of an expert on these params, but looking at upvoted stackoverflow answers, I think these defaults should be removed from the formula if possible.

swappiness Q&A on stackexchange
"The default value [60] has most likely been chosen as an approximate middleground between these two extremes. As with any performance parameter, adjusting vm.swappiness should be based on benchmark data comparable to real workloads, not just a gut feeling"

fs-file-max Q&A on stackoverflow
"For fs.file-max, I think in almost all cases you can just leave it alone" and
"The 2.6 kernel automatically tunes fs.file-max based on available memory"

# -*- coding: utf-8 -*-
# vim: ft=yaml
sysctl:
  pkg: procps-ng
  config:
    location: '/etc/sysctl.d'
  lookup:
    params:
      -
        name: fs.file-max
        value: 100000
        config: fs.conf
      -
        name: vm.swappiness
        value: 20

Appears this wasn't working with RedHat family 6/7. /etc/sysctl.conf is a file, but was being used as a directory. Also, /etc/sysctl.d exists on both. Finally, the package names are different for 6 & 7. I've created #20 to resolve.

Hi, it would be great if you could create tags on all formulas (quarterly, monthly,...) so they could be easily used without risking future updates breaking something. This way users could easily use formulas as:

gitfs_remotes:
  - https://github.com/saltstack-formulas/sysctl-formula:
    - base: <Some tag>

without creating fork for each formula they use. Then as formulas are updated users could test new versions and pull them in their system in a more controlled way.

The goal of the previous PR is to update https://github.com/saltstack-formulas/sysctl-formula/blob/master/sysctl/map.jinja and remove the ugly backward compatiblility patch.

@myii how do you want to do?

Do you think that params should be set as dictionary instead of array? With current implementation it is impossible to override defaults params without redefining all of them. E.g. if i set defaults like this:

sysctl:
  lookup:
    pkg: procps
    config:
      location: '/etc/sysctl.conf'
    params:
      - name: net.ipv4.ip_forward
        value: 1
      - name: net.core.somaxconn
        value: 65536
      - name: fs.file-max
        value: 65536
      - name: vm.swappiness
        value: 60

and want to override some param, e.g vm.swappiness for certain set of servers I'd need to redefine all params above instead of just redefining vm.swappiness. But if params were set like dictionary:

sysctl:
  lookup:
    pkg: procps
    config:
      location: '/etc/sysctl.conf'
    params:
      net.ipv4.ip_forward:
        value: 1
      net.core.somaxconn:
        value: 65536
      fs.file-max:
        value: 65536
        config: fs.conf
      vm.swappiness:
        value: 60

overriding vm.swappiness would require following configuration:

sysctl:
  lookup:
    params:
      vm.swappiness:
        value: 20

Thoughts?