saltarelle / saltarelleknockout Goto Github PK

to create an Observable, the static creator Knockout.Observable<T>() has to be called instead of the natural class constructor (which is not implemented and marked as internal).

My proposal is to implement a proper constructor so that observables can be created with new like in:

var h = new Observable<string>("hello");

I was thinking of something like this in Observable.cs:

        [InlineCode("ko.observable()")]
        public Observable() {
        }

        [InlineCode("ko.observable({value})")]
        public Observable(T value) {
        }

what do you think? IMO it would make the code nicer to read.

public void Splice(int index, int howmany, params T[] args) should be decorated with [ExpandParams] attribute since the args parameter should not be compiled as an array, but a list of items.

I've pointed to this on the forum
http://saltarellecompiler.freeforums.org/post134.html

In the latest release, ModelToObject takes only one parameter, while in a previous release it had an overload that takes an extra mapping options parameter.

In the original JS Knockout Mapping file:
https://github.com/SteveSanderson/knockout.mapping/blob/master/knockout.mapping.js
toJS (Which is named ModelToObject in Saltarelle) is defined in line 160, and it takes two parameters, rootObject and options. So, why the options parameter was removed from Saltarelle and Script#? I'm sure this parameter was in a previous release, because I wrote code that uses it.

These are used to specify the default ignore, copy, observe and include behaviours of the plugin. These are part of the plugin
https://github.com/SteveSanderson/knockout.mapping/blob/master/knockout.mapping.js
I used to add these myself while I was including Knockout as source code, but now I can't because I use the Knockout Nuget package. I can just add these as extension methods, but I hope they're added to the library.