salines / cakephp4-soft-delete Goto Github PK

Please, update your library on line 60 of the file SoftDeleteTrait.php.
Change the line with:
$primaryKey = (array)$this->primaryKey();
with
$primaryKey = (array)$this->getPrimaryKey();

Regards

Thanks for this nice library!

It would be awesome to be able to return only the deleted records. For this a new custom-finder could be implemented.

Something like:

$user = $this->Users->find('all', ['onlyDeleted']);

Implementation could be:

public function triggerBeforeFind(): void
    {
        if (!$this->_beforeFindFired && $this->_type === 'select') {
            parent::triggerBeforeFind();

            $aliasedField = $this
                ->getRepository()
                ->aliasField($this->getRepository()->getSoftDeleteField());

            if (!is_array($this->getOptions()) || !in_array('withDeleted', $this->getOptions())) {
                $this->andWhere($aliasedField . ' IS NULL');
            }

            if (!is_array($this->getOptions()) || !in_array('onlyDeleted', $this->getOptions())) {
                $this->andWhere($aliasedField . ' IS NOT NULL');
            }
        }
    }

Best regards,
Patrick

In my project the soft-delete plugin stopped working with the update to cakephp 4.5.
The triggerBeforeFind Method is only executed with update queries and not select queries. Therefore the "deleted IS NULL" clause is not appended to the where-statement. I suspect it goes back to this change in 4.5: https://book.cakephp.org/4/en/appendices/4-5-migration-guide.html#orm-query-api-deprecations

hardDelete return "Unknown method "primaryKey" called on ..."