all http methods should look like this:

FuelRestClient.get( '/my/url/here/', options, function() {});
// OR
FuelRestClient.get( '/my/url/here/', function() {});

allow for token to be passed into http method functions if there is no FuelAuth

get( uri, qsParams, options, callback )

will be merged into requestOptions like post data for all other

this leads to unexpected behavior

better readability

Right now, in order to ensure all requests just default to the (better) Fuel data version 1.1, the only good way looks stupid:

var FuelRest = require('fuel-rest');
var fuelRestClient = new FuelRest(options);

fuelRestClient.defaultHeaders['x-fueldata-version'] = '1.1';

I'm not sure if we should add an option explicitly for "fuelDataVersion", but at least if there was a constructor option to add to default headers, that would be a good general solution :)

It would be really helpful to have a more comprehensive set of examples, especially while there are discrepancies between the SOAP and REST APIs. Specifically a post request.

• refactor constructor for better initialization
• update API for http methods
• add required headers (authorization - forgot that one)
• etc.

This will allow us to pass in auth headers to the requests, and remove overhead of extra token requests when they are unneeded

Would it be possible to add an option to configure proxy settings?

We're using a modified version of this library like this and would like to switch to a non modified npm version for obvious reasons.

Line 100
options.uri     = helpers.resolveUri(self.origin, options.uri);
                options.headers = _.merge({}, self.defaultHeaders, options.headers);
                options.headers.Authorization = options.headers.Authorization || 'Bearer ' + authResponse.accessToken;
                if(proxy.useProxy()) {
                    options.proxy = proxy.getUri();
                }
                options.rejectUnauthorized = merck.security.rejectUnauthorized;

Hello,
can you please provide an example how to call APIs accessible from auth server?
E.g.: https://{{MC_ENV}}.auth.marketingcloudapis.com/v2/userinfo?
Regards,
Filip

Allow REST client to accept an already initialized FuelAuth instead of initializing it's own

need to merge the path provided with the endpoint passed in at initialization

Since the soap and rest libraries both would utilize fuel with, would it make sense to not set it as a requirement, or am I misunderstanding the implementation?

I would think you would create the Auth object outside of this and the soap lib.

Would love some support, care and attention of this repo from Salesforce.

npm WARN deprecated [email protected]: 🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read https://babeljs.io/env to update!
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam

Primarily request has been deprecated for over a year now.

I've been reluctant to contribute as issues, pull requests and comments are ignored.

For those of us using Typescript or similar, it would be nice if there were some type definitions for this library.

I looked for a types package in NPM under the standard @types namespace but it appears none has been created:

$ npm install -D @types/fuel-rest
> npm ERR! code E404
> npm ERR! 404 Not Found: @types/fuel-rest@latest
> ...

It deletes the campaign but .then(response) returning null.

Got this error when posting a new Campaign:

then [Error: Argument error, options.body.]  (see code below)

typeof(response) returned "object". util.isArray(response) returned false. Really couldn't do anything with the "object". Trying to access response.Error was not possible. I'd like to return the error back to the client but the only thing I could is print it to the console.

this.parent.RestClient
    .post(options)
    .then(function(response) {
        //console.log('then',response); //<---- **** tricky result type when there's an error here.
        cb(response); 
    }.bind(this))
    .catch(function(err) {
        cb(err);  
    }.bind(this));

The dependency fuel-auth was updated from 3.2.1 to 3.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

fuel-auth is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Prior to version 2.47.0 the request npm module was using tough-cookie < 2.3.0 which has a high ReDOS vulnerability rating. They have updated to use the newest version of tough-cookie that does not have the vulnerability in >= 2.47.0 version of request.

Read more:
https://nodesecurity.io/advisories/130
https://snyk.io/vuln/npm:tough-cookie:20160722

When trying to use /push endpoint toLowerCase() call on helper method removes case on messageId parameter and request fails because ID is not found ( due to messageId case).

How can we use our tenant specific domain for Auth and REST calls?

I can find origin in options object. Which one to use there and where to use the other one?

Example of auth domain: https://mc3blub.auth.marketingcloudapis.com/
Example of REST domain: https://mc3blub.rest.marketingcloudapis.com/

Thanks!

Version: 2.0.5

On get | post | put | patch | delete requests, the retry options is true by default.
Ideally this will re-fetch the access token and make the request again after receiving a 401 error.

However, by the following logic in _processRequest function, the Authorization header will only be updated when it doesn't exist, which means the second request will still take the old token and then always get a 401 error again.

if (!options.headers.Authorization) {
	options.headers.Authorization = 'Bearer ' + authResponse.accessToken;
	retry = options.retry || false;
}

I'm trying to make a simple GET request using OAuth 2.0 and grant_type: 'client_credentials' but i keep getting an error. I followed the readme doc to initialize and make a request like below.

const FuelRest = require("fuel-rest");

const options = {
  auth: {
    clientId: "CLIENT_ID_HERE",
    clientSecret: "CLIENT_SECRET_HERE",
    authUrl:
      "https://MY_AUTH_URL.auth.marketingcloudapis.com/v2/token/", //Tried without '/v2/token/' also
  },
  origin: "https://MY_ORIGIN.rest.marketingcloudapis.com/",
};

const RestClient = new FuelRest(options);

const getOpts = {
  uri: "/platform/v1/endpoints",
  headers: {},
  // other request options
};

RestClient.get(getOpts)
  .then(function (response) {
    var result = response && response.body ? response.body : response;
    console.log(result);
  })
  .catch(function (err) {
    console.log(err);
  });

Error i am getting is

{ Error: No access token
    at AuthClient.getAccessToken.then.tokenInfo (E:\Development\node-scripts\node_modules\fuel-rest\lib\fuel-rest.js:88:18)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
  res:
   { error: 'unsupported_grant_type',
     error_description: 'Use "authorization_code" or "refresh_token" or "client_credentials" or "urn:ietf:params:oauth:grant-type:jwt-bearer" as the grant_type.',
     error_uri: 'https://developer.salesforce.com/docs' } }

Please let me know if i did something wrong with the initialization or misunderstood the docs.