Code Monkey home page Code Monkey logo

saleor.io-learn's People

Contributors

2can avatar krzysztofwolski avatar krzysztofzuraw avatar l3str4nge avatar lkostrowski avatar maarcingebala avatar melwynt avatar mirekm avatar mjbedi avatar pawelpikus avatar pearldickens avatar peelar avatar zaiste avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

saleor.io-learn's Issues

Use Next.js image component

It will be nice to migrate to the Next.js image component instead of using the HTML <img /> tag. During the process, we can add alt descriptions to all images as well ๐Ÿ˜„

Search is not working

Try to search smg by search

Result: 404 page not found is shown

Sep-28-2021.15-19-54.mp4

Broken images in Saleor CLI

The images within Saleor CLI set of articles are not loaded. Please provide the proper path to images folder.

Syntax error when running the Sorting Products code

Hello,

I am running the tutorial step by step and have encountered a syntax error when running localhost on the Sorting Products step.

I have copied the code in the query and component, and ran the npm run generate to create the React hooks but when I am running the development server the page does not display and I have the following error:

TypeError: Cannot read properties of undefined (reading 'Name')
  20 |       filter: { search: 'T-Shirt' },
  21 |       sortBy: {
> 22 |         field: ProductOrderField.Name,
     |               ^
  23 |         direction: OrderDirection.Desc
  24 |       }
  25 |     }

I have to add that I populated the database with the sample data and running SALEOR VERSION 3.4.10.

Could you help me solve that issue ?

Thanks

Persist token on refresh issue

This page https://learn.saleor.io/checkout/checkout-creation/ at the bottom says:
At this stage, the checkout session exists in the application state as long as you don't refresh the page

I can see this is because on refresh the code will generate a new token each time! This results in the cart being cleared out.

I cannot see anywhere on the checkout docs where you fix this issue and make it persist on page refresh.

I used the following code which works, not sure if its the correct approach:

if(token == undefined)
{
    setToken(token);
}

Content around 'blocking' in "Adding ISR to Product page section"

And then, whenever the product page than these 4 pre-generated, we will block the request till the product page is generated using fallback: 'blocking'.

Something's wrong with the first part of the sentence above. Also the second part is not fully clear to me we will block the request till the product page is generated using fallback: 'blocking'. especially given that it's in the section titled Pages to generate at build-time. Probably worth a sentence of two of explanation or rephrasing?

Token not generated when deployed to Saleor, but works on localhost

Following this tutorial works for localhost. I can see the token being generated.
https://learn.saleor.io/checkout/checkout-creation/

When I deploy to Vercel the token is not generated.

data returns checkoutcreate that includes the token though, so this code is not picking it up when on vercel, but it does on localhost.

console.log(data)

{
    "checkoutCreate": {
        "checkout": {
            "token": "e2dd379b-b7dc-4619-9853-55cecb607461",
            "__typename": "Checkout"
        },
        "errors": [],
        "__typename": "CheckoutCreate"
    }
}

Is the code example correct?

Broken Link

The header of https://saleor.io/ has the wrong link on mobile. Currently the "Saleor Tutorial" links to "httpshttps://saleor.io/learn" should be "https://saleor.io/learn"

While this does not apply to https://saleor.io/learn directly, I could not find a repository for the main site. If there is a better place for this issue, please close this and open a new issue there.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.