sal0max / currencies Goto Github PK

I suggest you make the app's title name translatable. It'll be much nicer and convenient to see it in your native language in the app drawer.
A lot of apps, open source or not, follow this. Thanks in advance!

Implement multiple API providers and let the user choose his favorite one in the settings.
Gives some redundancy, when an API shuts down unexpectedly, again.

Don't forget: When changing API, change the "data source" explanation text accordingly

When refreshing the rates without an internet connection, the app crashes.
I found that this was a problem while traveling without an internet connection. The app wanted to refresh the rates automatically on opening the app so it crashed immediately.
I don't really mind outdated rates but I guess for others it would be useful to show an alert that the rates are outdated.

Thanks for the app, love the simplicity!

This is a brilliant app with all the key information, but open source and without ads -- many thanks for your hard work!

The screen I use the most in other apps like this is an overview screen that has my "home" currency and then my favourite currencies listed with their conversions from 1 of my home currency, e.g.

GBP 1.00

USD 1.20
EUR 1.35
NZD 1.95
AUD 1.85

The normal screen, letting you actually convert specific amounts is helpful when you need to be more precise, but normally having an up-to-date reference of "+20%" or similar is enough to get me through the day when travelling. Hopefully that feedback is helpful.

I'm a PhD student interested in finding security vulnerabilities in open source projects.

We found a total of 5 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on currencies (or its library dependencies). We documented each one of these issues in private gists for the sake of confidentiality (non-disclosure).

Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve currencies's security, and the quality of the reports of static analysis tools.
(*) https://github.com/CROSSINGTUD/CryptoAnalysis

In many languages, the currency symbol or the ISO code follow the amount, not precede it, i.e. 23,1 € or 1$, more information here. Additionally, Croatian has a whitespace before the symbol.
Would it be possible to implement this on the main screen, the same way decimal point and separator are handled in the translation?

.

I am finding that this app is not working.
Am getting HTTP 521 Error

Add an EXTRA currency which is linked to the Dollar or Euro that the user can set a custom exchange rate for.

If the desired currency isn't available you can simple use the EXTRA currency.

It would be nice to have some functionality of this app as a widget so information could be available "at-a-glance". Potentially it would show a list of (user-selected) exchange rates or give access to the calculator directly on the homescreen.

Let me know your thoughts!

Could you please check the screenshots in fastlane? You've added them as symlinks to local files on your Mac – that won't work:

https://github.com/sal0max/currencies/blob/master/fastlane/metadata/android/en-US/images/phoneScreenshots/screen01.png
=> /Users/maks/dev/android/currencies/art/screenshots/screen01.png

Please replace those symlinks by the real images in your Git tree (and either reverse the symlinks' direction or use hard links instead). Thanks!

The missing languages in the Weblate that I'm proficient in are Dutch and Bosnian.

English and German are already included (and finished), and if it's possible, you could include Serbian and Croatian (because Bosnian is essentially the same as them, but with very minor dialect differences).

Hello, I love your work. At the moment only two currencies can be converted by default in this software. I would like to see the possibility of customising the conversion of multiple currencies. I would like to support more options such as virtual currency. Sorry for the inconvenience. Have a nice life.

With the loss of exchangerate.host the number of currencies supported by this amazing app has dropped considerably.

Would you consider adding support for Open Exchange Rates? They offer a forever free plan that's limited to two API keys and 1,000 API calls a month, more than adequate for the target audience of this app, i.e., casual travellers.

I appreciate this is more of an advanced feature since not everyone knows what an API is, but it's not exactly rocket science either. It is supported by at least two other apps on F-Droid: My Expenses and STARGW FX, and both provide very basic instructions on what to do (essentially register a free account on openexchangerates.org and provide your API key/App ID here).

It would greatly increase the amount of supported currencies (over 200), with the benefit of hourly updates.

I implore you not to use Codeberg on account of their stance against freedom https://codeberg.org/Codeberg/org/src/branch/main/TermsOfUse.md
This rug-pull operation was neither mentioned up front, or to users later.
After that there is no tangible reason to use Codeberg, as that was its one and only premise to operate by.

https://hosted.weblate.org/ OTOH has a great record in the service of freedom, and is maintained by Weblate staff.
Its community is also greater.
Its services are on offer for libre projects via https://hosted.weblate.org/hosting

Migrating by asking bubu for the files is a better way of going about things, as that way authorship is maintained.
This info is essential to ensure quality, and it does also put credit where credit is due.
It wasn't the erosion of freedom I for one wanted to contribute to, and I have very little else left since I don't care as much
about credit.

I can help out by adding Swedish and Danish, and also configure things if needed. "kingu" is my account.

I would like to have an material design theme in the app.

Latest version 1.10.1 crashes when tapping the settings button, on Android 10. I've sent a crash report through Android.

HI, and congrats on this really awesome app, the best of its kind!
I have a little question: are the rates updated everyday on the background or only when the app is launched? I hope the 2nd is happening, which makes sense after all, and saves data.

In Indonesia most prices are multiples of 1000. A button to aromatically add 3 zeroes, or a feature to always assume 3 zeroes would be handy when comparing prices op products

On most smartphone screens, some text of the spinner items is too long to be displayed.
This causes the currency code to not be visible

Maybe use a two-row layout instead?

The chart would be more useful if it would contain a grid, values on y axis and date on x axis.
Also the precision should be higher in some cases like here:

Thanks for the great app.

It would be great to add a feature to convert currencies with historic transfer rates. This could be done by adding a datetime picker to the main screen. What do you think about it?

Hi 👋🏼

in addition to #8 I'd like to add that having charts displaying historic rates would be another great feature.

I also found the library AAChartCore-Kotlin googling for possible solutions.

To precise my proposal please see this working (web) app: https://forexrate.web.app/

I have to admit that I'm not a android dev myself so I can't estimate the time and effort needed to integrate this idea.

Looking forward to your answer. Greetings, Petra

Today Georgian Lari disappeared from the app. Nothing helps to get it back: neither changing provider of the rates nor clear cache or storage.
See files attached

Such as BDT

Hi @sal0max

I installed the latest version today and noticed the following. Apparently there's a legacy url to the old weblate project in the F-Droid metadata.

# excerpt from de.salomax.currencies.yml
Categories:
  - Money
License: GPL-3.0-or-later
AuthorName: Maximilian Salomon
AuthorEmail: [email protected]
SourceCode: https://github.com/sal0max/currencies
IssueTracker: https://github.com/sal0max/currencies/issues
Translation: https://weblate.bubu1.eu/projects/currencies/  # <--- should be weblate.codeberg.org (?)
Changelog: https://github.com/sal0max/currencies/releases
Donate: https://www.paypal.com/donate/?hosted_button_id=2JCY7E99V9DGC

I understand that this might be not the right place to solve this as the issue concerns a file on GitLab. But as I unfortunately lack any prior experience with the F-Droid project itself I hope you might be able to resolve this.

Hi 👋🏼

while searching the fastlane directory I couldn't find a feature graphic for this app.

So I just created a (basic) draft using GIMP:

based on the svg images in the ic_launcher directory.

As mentioned above this is just a draft and might not be your liking.

I'll attach my GIMP .xcf file. Feel free to modify the image.

📁 currencies_app_salOmax_feature-graphic.zip

Getting this confusing error message whenever I use Exhangerate.host. Other providers seem unaffected.

This is 1.20.4 on a Pixel 6a running Android 13.
Thanks for taking a look, and apologies if this has already been reported.

This would make the app much more convenient. I am tired of going back and forth between a document and this app just to enter a price with not a lot of zeroes (for example, 1,949.50).

Hi 👋🏼

great app. Looks amazing 👍🏼 I love the design.

Any chance to add the cryptocurrencies provided by exchangerate.host?

Would love to see that implemented. Hope you have the time for that. Big thank you in advance. 🙏🏼

I'm very grateful for the time and effort you invest in this project.

Greetings, Petra

Thank you for the best currency converter on Google Play and F-Droid! It would be great if you will add two new screens:

1. Screen with all favorite currencies (this is more important).
2. Screen with all currencies.

Currently Currencies app have only screen with one currency.

You can download this converter and copy aforementioned features from it: https://play.google.com/store/apps/details?id=uk.co.currencyconverter&hl=en

I have changed my android system to the dark look. In the currencies app, I have set the system settings to load. Unfortunately, the app remains light and does not go dark

Please consider adding an option for a pure black/AMOLED black theme to the app. Thank you!

any chance to add custom currency/rates?

missing Omani OMR

I know the troubles with the api's, so adding a custom currency somehow would be very nice!

Hello,

Very nice looking app first of all

I regularly pay some people in bitcoin and it would be a nice addon if this app would support some cryptocurrencies. maybe as an addition setting to enable support would be nice.

Kind regards,
Herman

Got a message via mail:

The app works well, but on my Samsung Z Flip 3 I'm having problems with the app displaying incorrectly unless slightly folded.
When unfolded fully, the numpad covers the currency exhange rates.

Photos attached.

I think swiping down the main app screen, to update the currency rates would be a very convenient feature. How about adding it? 😊

P. S. Have a happy new year! 🎉🍾🥂🎅

Hi 👋🏼

it's me once again.

Progress

I just finished translating:

-> I plan to translate all files listed above very soon. Edit: done
-> I'm open for feedback and contributions.

Attachments

Notice GitHub still does not (seem) to accept .xml file uploads so the files have been 'converted' to .txt

strings.xml
📎 strings_fr.xml.txt ✔️
📎 strings_it.xml.txt ✔️
📎 strings_es.xml.txt ✔️

string_preference.xml
📎 strings_preference_fr.xml.txt ✔️
📎 strings_preference_it.xml.txt ✔️
📎 strings_preference_es.xml.txt ✔️

strings_currencies.xml
📎 strings_currencies_fr.xml.txt ✔️
📎 strings_currencies_it.xml.txt✔️
📎 strings_currencies_es.xml.txt ✔️

README.md
📎 README_de.md.txt
📎 README_fr.md.txt
📎 README_fr.md.txt
📎 README_it.md.txt

Edit: ✔️ -> uploaded to Weblate

live status of Translations @ weblate

Currently application settings language selection shows language names localized to currently active language.

In my opinion this doesn't make sense, and is actually harmful.

Consider following scenario:

1. User changed language by accident to some lang that they don't know.
2. They want to switch back
3. But language list is in foreign language and all language name are translated.

It would be really hard to select language in this case. And it would be hard to even fine English (as most common denominator) becouse it is also translated. Even worse if selected language is not using Latin charset. Then it woun't be possible to read even, if that's not language you know.

So my proposal is to display language list same way on each locale, so don't localize it.

Show language as native lang name + english lang name. For example Arabic (العربية)

This would be more useful. And actually what's the sense to show, say Polish language name in Arabic?

When you first open the app the app theme is Dark for a split second, even when the theme OLED Black is set. This is only visible on app startup from a non-running state.

I noticed that when the fer.ee provider is selected there's an issue. While in the main screen the rates are of yesterday's, in the graph screen today's rates appear. I don't know if that's a problem of the app or the provider, but it should be fixed.

Croatian doesn't show up in the language picker in 1.18.1, regardless of the system language. Croatian, however, works when Croatian is the system default language.

First of all, GREAT APP and Great Simple Design, thank you so much.

It would be great if a feature to define the conversion rate myself and lock it to prevent it from updating. This could serve two proposes:

1. Allow conversion based on purchasing rate of the foreign exchange.
2. Allow custom currencies such that your app suddenly is supporting unlimited number of currencies.

Hello !

After all, I need to tell you,
This is a really good application !
you have the devise AND the symbol (best when) you looking for the devise of a country

And my request is:
Is it possible to add "history" (with SQLite3/Text file or something like that?) Because sometimes I want to search directly the calc/value from my history than: found the device, found the value,...
or to see approximately

Regards.

Hi! Good morning, I really love your app! It really is very beneficial for me! one thing though, Idk if you will add this feature, but can you add mining currency as well? Maybe put it on another tab, once again, thank you for making this app.