Code Monkey home page Code Monkey logo

ped's People

Contributors

saiutkarsh33 avatar

Watchers

 avatar

ped's Issues

Not allowed to add a customer whose name exactly matches one already present in the address book

Actual behaviour:

Not allowed to add a customer whose name exactly matches one already present in the address book

The following error shows:

This person already exists in the address book

Expected behaviour:

Different people might have the same name. since deletion and edits are done via customer id itself, being able to add a contact with the same name will not affect other commands and will just add functionality to this application

Full phone number/ tag/ email required when using find command

To reproduce:

Given a very long number, tag, email, type find followed by a part of the number, tag or email.

Eg is the tag is "ilovecs2103somuchbutiamsoscaredofdevinihopehedoesnottakeover"

type find t/ilovecs2103

Expected behaviour:

All contacts with tags beginning with ilovecs2103 show up

Actual behaviour:

No contacts show up, as full tags are required.

Adding product does not work

As the adding to menu command is listed after the product and order commands, it was confusing. the menu command should have been written down before.

Cannot add more tags with edit command without removing all current tags

To reproduce

Given a contact with a tag, oldTag

type in edit c/[index] t/newTag

Actual Behaviour

the contact has only one tag - newTag and the oldTag disappears

Expected Behaviour:

As a contact can have multiple tags, it would only make sense for edit to add tags instead of replacing

In addition, there could be further functions to add or replace tags, to make this clearer.

Email does not need to have a domain name extension

How to replicate:

Add a new user with an email that does not have a domain name extension (eg .com)

eg add n/John Doe p/98765432 e/johnd@example a/John street, block 123,
#1-01

Expected Behaviour:

Throw an error stating that a domain name extension is required

Actual Behaviour:

Customer is added to the address book.

Screenshot 2024-04-05 at 4.28.42 PM.png

Minimum of 3 numbers are required for phone number

Actual behaviour

Phone number is minimally of length 3

Expected behaviour

As this product is for human customers, it is unlikely that the customer's phone number would deviate from the norm number length in Singapore (8). A better suggestion would be for the length to be 8 only. As there is no country code provided, I am assuming only Singapore phone numbers are allowed.

This would genuinely help in the situation where someone might accidentally type in a number of only 7 digits, allowing them to correct the error in real time.

Name can be just numeric

Steps to reproduce

Add a customer with just numbers as his name, eg

add n/123 p/98765432 e/[email protected] a/John street, block
123, #1-01

Expected Behaviour

Expected to see an error as a name cannot have just numbers

Actual Behaviour

A customer is added with the name "123".

Screenshot 2024-04-05 at 4.18.42 PM.png

Docs typo

Expected behaviour:

order p/87438807 by/08/04/2024 will create an order for person with phone number
87438807 with a deadline 08/04/2024 , start adding products for the order to be
shown.

Actual behaviour:

order p/87438807 by/08/04/2024 will create an order for person with phone number
99887766 with a deadline 08/04/2024 , start adding products for the order to be
shown.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.