sailfishos / droidmedia Goto Github PK

• move ACaptureRequest to the top (LineageOS/android_frameworks_av@ddf11b4)
• Android 8.1 has no ACameraWindowType but only ANativeWindow
• ACameraMetadata_isLogicalMultiCamera is unknown
• too new enums: ACAMERA_CONTROL_ZOOM_RATIO, ACAMERA_CONTROL_ZOOM_RATIO_RANGE, ACAMERA_CONTROL_AE_COMPENSATION_RANGE, other zoom implementation for older devices required

Using the torch from eg the top menu does no longer work with current camera2 branches

According to our CI your change at 4e40a44#diff-e1bdd5492dd0f95748bb1bdf8102ade83920a862c015d87338df05366935231bR782 broke compilation: See end of log at https://ci.ubports.com/job/UBportsCommunityPortsJenkinsCI/job/ubports%2Fcommunity-ports%2Fjenkins-ci%2Fmarlin-sailfish/job/main/149/console

Using std::stof will truncate floats if the decimal separator of the current locale is not .

std::to_string will print a localized decimal separator , in my case
https://github.com/sailfishos/droidmedia/blob/camera2-test3/droidmediacamera2.cpp#L1881

I'm a bit confused why I'm not seeing this in logs:

DroidMediaCamera: get_parameters result: video-size=-1x-1;video-frame-format=android-opaque;antibanding-values=off,50hz,60hz,auto;preview-fps-range-values=(15000,30000);preview-frame-rate=30;min-exposure-compensation=-12;max-exposure-compensation=12;exposure-compensation-step=0.166667;focus-mode-values=infinity,auto,macro,continuous-video,continuous-picture;effect-values=none,mono,negative,solarize,sepia,posterize,aqua,blackboard,whiteboard;scene-mode-values=auto,auto,action,portrait,landscape,night,night-portrait,theatre,beach,snow,sunset,fireworks,sports,party,candlelight,hdr;whitebalance-values=auto,incandescent,fluorescent,warm-fluorescent,daylight,cloudy-daylight,twilight,shade,;max-num-focus-areas=0;max-num-metering-areas=1;auto-exposure-lock-supported=true;auto-exposure-lock=false;auto-whitebalance-lock-supported=true;auto-whitebalance-lock=false;flash-mode-values=off,auto,on,torch;picture-size-values=4000x3000,3840x2160,3264x2448,3200x2400,2976x2976,2688x1512,2592x1944,2048x1536,1920x1440,1920x1080,1600x1200,1440x1080

because I assume I'm compiling for android 11: ANDROID_VERSION_MAJOR="11"

Currently the colors in camera preview are inverted.

For Xperia 10 III camera2 reports the following supported formats:

10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 32 20  AIMAGE_FORMAT_RAW16
10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 34 22  AIMAGE_FORMAT_PRIVATE
10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 35 23  AIMAGE_FORMAT_YUV_420_888
10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 36 24  AIMAGE_FORMAT_RAW_PRIVATE
10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 37 25  AIMAGE_FORMAT_RAW10
10-13 20:23:08.170  4552   942 I DroidMediaCamera: format 256 100 AIMAGE_FORMAT_JPEG

@mal dropped AIMAGE_FORMAT_YUV_420_888 in some places but commented it out, commenting it back in does not make it work unfortunately

The Sony Xperia 10 III has three cameras on the back but only one is announced currently. On Android the camera is switched automatically based on zoom level but ACameraMetadata_isLogicalMultiCamera returns false here:

Do we need to enable this somehow? Is there another way to switch cameras?

Some links:
https://developer.android.com/media/camera/camera2/multi-camera

https://developer.android.com/ndk/reference/group/camera#group___camera_1gga8480a8f9e2ee6f1ad2489ee1649f9ef9ad0531bfb7b50c1e6dd4ff85b630b790e

The docs also talk about fancy multi camera modes with stuff like bokeh effects by combining several cameras etc. Do we expect these to be implemented and unlockable here?

But works in viewfinder mode

The current stub implementation returns nullpointers everywhere. This makes the camera app crash.

• Add nullpointer checks so the camera app no longer crashes (?)
• Implement video recording
• Add more substeps
• Add a project or milestone (maintainer needed)

Hello, I am building this package,I have resolved the dependeces,but I still can't find the command "droid-make". 🆘
my OS info:
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
my SDK info:
SDK_RELEASE=3.5.7
SDK_RELEASE_CYCLE=Stable
SDK_CONFIG_DIR=SailfishSDK
SDK_VENDOR="Jolla"

Please tell me how can I get the droid-make command.
Thanks! 🌻