iOS 11 Crashes - Invalid State Transformation while Evaluating Conditions about overdrive HOT 11 OPEN

from overdrive.

I have gotten around this temporarily by replacing
assert(internalState.canTransition(to: newState, isCancelled: isCancelled), "Invalid state transformation from \(internalState) to \(newState)") internalState = newState

with

if(internalState.canTransition(to: newState, isCancelled: isCancelled)){ internalState = newState }

in TaskBase.swift (state variable setter)

For the time being, this fixes the crashes, as well passes the tests on the iOS 11 simulator. This is basically preventing invalid state transformations.

from overdrive.

Hey, could you get the time to look at this?

from overdrive.

from overdrive.

@biocross you say that you've ran unit tests on Xcode 9 beta, does that mean that you converted project to Swift 4? I'm currently running tests on Xcode 9 and every test is passing. If you're interested in that you can look into swift4 branch of the repo.

However, you have a problem in production with iOS 11. Could you supply me with a piece of code that can showcase problems you're having? Then, I'll be able to investigate more.

from overdrive.

I didn't convert the code to Swift 4. Basically, due to evaluateConditions being called twice on tasks, the task is moving to the ready state twice, leading to an assertion failure in TaskBase.swift, and crashing in debug. In release mode, even if the assertion is disabled, invalid state transformation end up crashing my tasks.

from overdrive.

Hey one thing, tests pass for me in Xcode 9, if I target my mac. Did you target an iOS 11 simulator to run the tests?

from overdrive.

Hey, any update?

from overdrive.

I have confirmed that there is a different behavior between iOS 10 and iOS 11, still trying to figure out why. I should have a fix by the end of the day.

from overdrive.

Looks like the behavior of several KVO methods is slightly changed in iOS 11. For now, you can try out fix in the conditions-fix branch.

It's mostly a hack until I rewrite some of the internal stuff, but it should work.

Let me know if it works for you.

from overdrive.

Alright. Thanks a lot! Seems to work, considering the tests pass.

from overdrive.