safijari / decky-recorder-fork Goto Github PK

Copied from marissa999/decky-recorder#32

Why? Because 30 sec clips are too big to be uploaded to Discord without having Nitro :)
15 secs would be perfect

The plugin stops working after the deck is suspended with "The recording is too short" (or something along the lines of) error. Reloading the plugin solves the issue. Would be nice if the plugin reloaded itself upon system wake-up, however i am unsure if decky loader provides a callback for that. This issue was supposedly fixed, as mentioned here. Close this issue if a fix isn't possible

Nor Repay or record modes. Tested on 3.4 and 3.5 :(

No error messages are shown for record mode, they're for replay mode ("too soon to record another clip")

Copy of marissa999/decky-recorder#30

Someone in the Deck Homebrew Discord mentioned this, but apparently a new filename addition includes colons, which are illegal for filenames in Windows, prompting the files to individually require renaming when transferring them to Windows. Any chance of changing out the usage of that character?

Please implement possibility to upload already captured video to youtube

Related to marissa999/decky-recorder#48

Not sure if it's a part of the branch you mentioned in the comment in that issue. Please feel free to close it if it's already a thing.

I just want to let it not record when there's no game running to save the device some battery. Thanks!

This can be manually fixed by switching replay off and on again after the restart. While in this error state, the buttons are greyed out.

Logs.zip

Like the title says, using Decky Recorder often causes a black screen and no input allowed when switching to Desktop Mode. The only thing you can do then is a full restart back to game mode by holding the power button. Uninstalling Decky Recorder fixes the issue. Not sure why this happens…miss this plugin :(

How do we set the image quality? At the moment it looks like a bad cctv camera with block compression.

Usually with anything media this can be avoided by changing whatever the quality setting is. For example most cctv cameras by default have crappy compression on to save space but most of us save to a NAS so storage is NOT an issue and we turn the quality back up to 100.

Just need to know where it is set?

Thanks

Hello.
With the Steamos 3.5 preview and the latest client preview (as of September 30, 2023) the recordings are unusable; I constantly have green frames in them.
https://www.dropbox.com/scl/fi/st9n2gbm3rcgcz3acho9q/2023-09-27-19.15.51.mp4?rlkey=hjhwug1v1j1vumygsh07y5ehx&dl=0

If I set the recording location to be the SD card, but the SD card is not plugged in, or for whatever reason SteamOS doesn't see it for whatever the reason, attempting to capture a replay will show the "Saved clip" prompt, even though nothing is being saved. And the same applies for manual recordings. Starting a manual recording, and re-opening the quick-access menu will show the text "Stop Recording", even though a recording isn't happening.

Any chance of this being fixed, even with a simple "Error: Can not write to directory" prompt?

I have i issues on my emulator, the sounds didn't captured only gameplay and then the other they captured by its delay sounds.

When uploading clips to twitter which is what I primarily use this for, the audio codec that is chosen by default doesn't work. I think I only got it to work after re encoding the whole video which ruined quality further. Reddit works fine but Twitter is my main form of social media.

When Replay mode feature is enabled, there is a chance that Desktop mode may not load properly, leaving black screen instead. While trackpads' haptics are working, nothing (cursor or other elements) is visible, which forces end user to reset SD by holding Power button.

Possible workaround: turn off Replay mode before switching to Desktop environment.

SteamOS version: 3.5.17
SteamOS build: 20240228.2
Tested version: 0.3.6
Testing method: switch to Desktop mode and back to Gaming mode in rapid succession.
Replay mode OFF: issue doesn't occur after 10 tries.
Replay mode ON: issue occurs on the 3rd try.

Copy of marissa999/decky-recorder#13

Thanks for this plugin! Since continuous recording might tax the battery, and I usually know what I want to record, can there be a separate hotkey to start/stop recording, rather than having the recording be on continuously?

I've been trying to diagnose and see if I can find any patterns in the current release and beta for crashes, using both mkv and mp4. The only common denominator is length of the recording, and that's not even always the case, I had one test that was an hour and forty four minutes, but then another one that suddenly stopped at twenty seven minutes.

No changes in audio, plug status, bluetooth, or power on these crashes. And the things that I'd assume would crash don't when it's a short file, even putting the device in sleep mode not only doesn't corrupt the video file, but it continues recording when waking the deck back up. That was in a single minute test, trying to find any patterns of buttons or something. It's also not intensity dependent, in the twenty seven minute corrupt file I mentioned earlier, there were some intense cpu and gpu heavy effects earlier, but this crash happened during inventory management.

These crashes are silent too, it still says "stop recording" when you open the panel. I'm curious if there is a way to have the application notify when it's no longer writing to the file, since the crashes just halt the recording as file size is consistent with the duration before the crash, not what it would be if it kept recording.

Another potential bandaid solution could be a setting to auto split the file every set amount of minutes. It stops the recording and begins another one automatically.

Could any of this be implemented? Is any of this data useful? I want to try to help get this working, and I'll keep testing, but the only consistent thing I've come across is the longer the recording, the more likely it is to fail. Usually at an hour, the hour and forty minutes is an outlier. Is there anything I can do to help?

HI, i tried to update my steamdeck with steamOS 3.5.17, i tried to install decky recorder from decky plugin store with version 0.4.0 but i still got this message

How do i fix this ?

When I ran make init initially, it failed stating:

+ env
bash: jq: command not found
make[1]: *** [env] Error 127
make: *** [init] Error 2

This was easily fixed by installing jq, but it should be stated in the README.md that it is required.

On gaming mode tried recording without docked no issues, the gpu can reach 1600 mhz and the game reach 60 fps. Playing while docked can also reach 1600 mhz, but when start recording it goes 25 fps and 1040 mhz on desperados 3 on any setting in-game and with/without fsr. Tested on other game also the same. I am using 3.5.7 stable

This occurs every time a user updates Decky Recorder and the GStreamer version library is changed or every time a user updates SteamOS and the GStreamer version library is changed.

Maybe dynamically loading this library will fix the issue?

@siglmf - "SteamOS includes GStreamer and Decky Recorder includes some additional libraries for that, and if there is a version mismatch between those, then recording will fail silently. Decky Recorder just starts the gst-launch-1.0 process (which fails immediately), and then it never checks the status of that process (until after you stop the recording), so it does not notice or report any issue."

0:00:00.002044135  5821 0x55c7c9ffb800 WARN      GST_PLUGIN_LOADING gstplugin.c:491:gst_plugin_register_func: plugin "/home/deck/homebrew/plugins/decky-recorder/bin/gstreamer-1.0/libgstsbc.so" has incompatible version (plugin: 1.22, gst: 1.20), not loading
0:00:00.003126953  5821 0x55c7c9ffb800 WARN      GST_PLUGIN_LOADING gstplugin.c:491:gst_plugin_register_func: plugin "/home/deck/homebrew/plugins/decky-recorder/bin/gstreamer-1.0/libgstcodecalpha.so" has incompatible version (plugin: 1.22, gst: 1.20), not loading
0:00:00.004118218  5821 0x55c7c9ffb800 WARN      GST_PLUGIN_LOADING gstplugin.c:491:gst_plugin_register_func: plugin "/home/deck/homebrew/plugins/decky-recorder/bin/gstreamer-1.0/libgstaudiovisualizers.so" has incompatible version (plugin: 1.22, gst: 1.20), not loading

Reference: marissa999/decky-recorder#52

Could you add feature to change the hotkey for recording?
I’d like to use R4 instead of steam+start. It would be great if user can choose own hotkey.

I don't know if I'm the only one with this issue, but every time I wanna record the last 30 seconds or 5 minutes of game play, the options are all grayed out. While other times it works. 90% of the time it doesn't work, any idea why?

I have no idea why, but for some reason, regardless of container; the recorded video is dark.

It doesnt even leave a file behind when this happens. Here are my logs:

logbkp.zip

So, after I finished recording a couple of times, I noticed that something was wrong with the video files it generated as I couldn't skim through them or see the length. It only let me watch the video from the beginning and was unrecognizable by my video editor. While I worked around this issue the first time by uploading the video to YouTube and downloading it from there, this is not an ideal solution and would like to know what's going on and how to prevent it happening. The two games that it has done this to me are BlazBlue Calamity Trigger and Persona 4 Golden. The BBCT one is only about six minutes long while the P4G one is about an hour and a half. You can find copies of both those files here: https://drive.google.com/drive/folders/1VbTcqTF_aS7wYrR2fSn2LSb9dxx8bYKN?usp=sharing

EDIT1: This next one is a relatively minor issue in comparison, but I noticed there's slight audio lag when you suspend the Deck while recording. That one is moreso a minor annoyance, but I figure I mention it since I'm here.

EDIT2: After uploading the P4G file to YouTube, I noticed that it cut off close to the one hour mark even though I recorded for way longer, and there was no indication that this happened whatsoever. I think this needs to be addressed as well.

EDIT3: Just reorganized the folder to better compartmentalize files, so I updated the link.

Issue: When recording long videos in Decky Recorder, the audio in the recorded video will have audio stuttering that was not present in the original gameplay.

Example:
In the video below, the audio stutters during the following segments:

• 25:23 - 27:59
• 47:03 - 49:59
• 59:47 - 1:05:03
• 1:14:38 - 2:49:03

https://www.youtube.com/watch?v=pTk36twdfXI

Details:

• Playing Parallel Launcher (n64 emulator) running Mario 64 romhack B3313
• Running Decky Recorder 0.4.1
• Issue was inconsistent. Would only happen during some recordings.

Hi, love this plugin, thanks for picking it up.

I'm running it on Bazzite on my Legion Go, so this is technically an unsupported case that I'm happy to PR myself or even build a fix specifically for me, but was hoping you might be able to provide some insight before I dig in.

Manually starting/stopping recording works perfectly, but saving a rolling recording gives me the "Clip saved" notification without saving the file.

Do you think it's more likely that enabling rolling recording isn't actually starting to record, or that it's more in the area of saving?

Hello, and excuse me if I am being oblivious when the feature already exists. If it doesn't, though, here is my request: would it be possible to implement UI for the user to be able to assign the STEAM+Start combo to be any amount of time instead of only 30 seconds?

I just noticed that this plug-in doesn't work for the game Fate/Samurai Remnant.
The notification, when I try to save replay, says "clip saved" but no video is generated in the directory.

I'm just assuming here, but I imagine it's because of the forward slash in the game's title.
Filenames for the screenshot uses the game's title and an error probably happens which ends up the files not being saved. Took me 10 hours to realize my replays are not being saved, so if my recordings actually ended up somewhere that's not "home/deck/videos", please tell me.

The gamemode check prevents it from capturing when using nested gamescope on desktop.

decky-recorder.log

Hi! I'm having an issue inspecting the recordings. They play OK in MPV, but trying to open them in MediaInfo or remux (say from MKV to MP4) with FFMPEG throws some weird errors.
In MediaInfo, I get a "floating point division by zero" error, in FFMPEG, I get a "time_scale/num_units_in_tick invalid or unsupported (0/1)" error. Sounds like the header information for these recordings is not correct.
This happens in MKV, MP4 and MOV.