Hey @s1e2b3i4 @rmehri01 ,
as you might know, I have recently been working in order to improve this theme. I am here to make a sort of proposal.
The theme here is defined using JSON. However, JSON does not have the concept of "placeholders", thus every color is duplicated on every rule. This not only makes the theme very hard to read (well, it's harder to read something like #ff0000
than red
), but also makes it hard to maintain (if we modify one color, all the occurrences of that colour have to be changed accordingly).
I have done a few researches, and in particular my attention was caught by how the dracula theme originators defined the theme.
As you see, they first define the theme using a yaml file and leveraging placeholders (in src/dracula.yml). Then, they (probably??) convert the theme into a JSON (the only format vs-code understand, I guess?) by using some JavaScript (inside of scripts/).
I guess it would be cool if we were able to make the same here. This will make the theme very readable and possibly attract more maintainers!
Unfortunately, I have no experience with writing JavaScript, thus I don't think I can help much when it comes to writing the js code that converts the yaml into JSON (well, I could look at the dracula code, but I had some issues understanding what was happening xD). I would however be glad to help in converting the JSON file into a YAML, if somebody was down to help :)
WDYT?