Code Monkey home page Code Monkey logo

chorus-client's Introduction

Hi there 👋

I am Lukas, and I am a software developer based in Vienna, Austria 🇦🇹

My main focus are Cameras 🎥,

but I also do some electronics 🔧

and home automation 🏠 projects from time to time.

🔭 I’m currently working on lots of go code, embedded linux, funkey protocols and much more

🌍 Check my Website: https://lbs.sh

chorus-client's People

Contributors

s00500 avatar

Watchers

avatar

chorus-client's Issues

Potential protocol issues

Hey, looks really nice!

Seems like in

chorus-client/src/main.rs

Line 195 in 4d8c80c

} else if result_str.contains("L") {

you are just checking if the string contains "L". This might lead to problems in the future if the protocol gets a new message, which might contain an "L" somewhere.

chorus-client/src/main.rs

Line 144 in 4d8c80c

//S0r004A\nS1r0044\nS2r0044

Might be another potential problem. These messages doesn't have to be in one packet and all other messages might very well be in a single packet. So every message should probably be split by '\n' and handled individually.
Also with v6 of the protocol individual modules are able to be disabled, so "S0r" might not always be present.

Perhaps you are already aware of this :) I just wanted to make sure, to avoid any future problems

Btw: Do you have any screenshots/videos? Would be really interested to see how that looks :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.