ryanriffle / vigilant Goto Github PK

The Plugin controller and model seem a little too complex. There should be a defined set of steps that should be taken to get a plugin installed and running and not have to skip fields like path or any other due to side effects that happen automatically each different way you can do it.

They should be built using sails.helpers to increase code reuse like some already are sails.helpers.pluginDetails().

My thought process on the what the flow of adding a plugin should be (again all in sails.helpers):

Adding Plugin

• Provide single field for stating the status of the process below and whether the plugin is ready.
  • In order to keep it simple, each step should deny working if the the step before it hasn't been completed.
• Provide endpoint to download plugin (Step doesn't have to download if it already exists on disk)
• Provide endpoint to install plugin dependencies.
  • This already has a helper sails.helpers.npmInstall
• Provide endpoint to update plugin based on package.json
  • This already has a helper sails.helpers.pluginDetails
• Provide endpoint to load the plugin in the vigilant.PluginManager
• Provide endpoint to unload the plugin from vigilant.PluginManager

Wrapper

• Endpoint to do every step in succession, returning the error immediately if failed.
  • Possibly the POST /plugin route

Plugin Deletion

• Provide endpoint for removing plugin from database but not disk
• Provide endpoint for removing plugin from disk and database