Comments (13)
Thank you all for your patience! I'm working with Next.js to figure out what the issue exactly is and how to remediate it
from storybook-addon-next.
So it seems that the following code no longer works
// .storybook/preview.js
import * as NextImage from "next/image";
const OriginalNextImage = NextImage.default;
Object.defineProperty(NextImage, "default", {
configurable: true,
value: (props) => <OriginalNextImage {...props} unoptimized />,
});
This has been the convention to getting next/image
working in storybook for a long time. I'm not sure why it is broken now. This is a compare between next 12.1.4 and 12.1.5 and nothing stands out to me as a major change.
I will continue to look into this, but if anyone has any insight, feel free to chip in.
A more detailed explanation for why this error is occurring is that when optimized={true}
on next/image
, the loader logic is run and thus creates the problems you are seeing. Because the code that automatically turns this off for you no longer works, you are seeing this error.
from storybook-addon-next.
I can confirm that after updating to 1.6.4
, images rendered correctly on storybook local, and production builds. And also on Chromatic
"storybook-addon-next": "1.6.4"
from storybook-addon-next.
I might put it in the repo but I was hoping to have clarification from the nextjs team if this is a bug on their end first.
I'm kinda torn on what to do. Put a workaround in this repo and risk breaking changes for y'all if nextjs decides to fix this problem, or wait until a decision is reached so we can implement a proper fix if needed.
from storybook-addon-next.
Thanks all for your patience. I know this was frustrating.
from storybook-addon-next.
Update:
There is a tentative workaround here. It should be good enough for most use cases
from storybook-addon-next.
Thanks for opening the issue! Do you currently have a workaround?
from storybook-addon-next.
No workaround currently, other than just using Next 12.1.4. Seems like maybe a lot of changes under the hood to next/image in 12.1.5.
from storybook-addon-next.
I am experiencing the same issue. I was wondering why, but @rsanchez is probably correct.
from storybook-addon-next.
Experiencing the same issue. Reverting to 12.1.4
for now seems to solve it.
from storybook-addon-next.
Like @jeroenroumen-acc , rollback to 12.1.4
fix the issue...
from storybook-addon-next.
@RyanClementsHax Thanks for tracking this down. Is that fix something you plan to incorporate into this plugin? Or are you suggesting we use that fix in our own code?
from storybook-addon-next.
🎉 This issue has been resolved in version 1.6.3 🎉
The release is available on:
Your semantic-release bot 📦🚀
from storybook-addon-next.
Related Issues (20)
- Does not work with `@nrwl/react/plugins/storybook` addon HOT 16
- Failed to load preset: /dist/preset.js HOT 3
- Next 12.2 newNextLinkBehavior support HOT 7
- I'm trying to use the addon with storybook and react, but can't build storybook once I installed the addon HOT 7
- Autoprefixer not working HOT 5
- Does not work with next/future/image HOT 3
- already written HOT 1
- Doesn't support AVIF format HOT 3
- Incopatibility with @storybook/builder-vite HOT 1
- Nextjs Image Error message Failed to parse src "static/media/public/logo.jpeg" on `next/image` HOT 3
- next 13 support HOT 11
- Error: NextRouter was not mounted. https://nextjs.org/docs/messages/next-router-not-mounted HOT 4
- Enabling react strict mode with this addon causes "Rendered more hooks than during the previous render." error. HOT 1
- Examples broken on next13, node 16.17.0 HOT 2
- Allow use of ES Module for NextJS config HOT 1
- Support Storybook v7 for upgrading HOT 9
- Nextjs Image Error message Failed to parse src "static/media/public/logo.jpeg" on next/legacy/image on Nextv13 HOT 1
- Image doesn't support the `loader` prop HOT 2
- Object.defineProperty(NextImage, '__esModule', descriptor) is no more needed from [email protected] HOT 4
- Next12.2 future/image support HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storybook-addon-next.